Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(EKS): outputConfigCommand does not work any more without mastersRole #32318

Open
1 task done
markusl opened this issue Nov 28, 2024 · 2 comments
Open
1 task done

(EKS): outputConfigCommand does not work any more without mastersRole #32318

markusl opened this issue Nov 28, 2024 · 2 comments
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. effort/small Small work item – less than a day of effort p3 potential-regression Marking this issue as a potential regression to be checked by team member

Comments

@markusl
Copy link
Contributor

markusl commented Nov 28, 2024

Describe the bug

outputConfigCommand does not output anything if props.mastersRole is not set.

Regression Issue

  • Select this option if this issue appears to be a regression.

Last Known Working CDK Version

No response

Expected Behavior

Output config command

Current Behavior

    const outputConfigCommand = (props.outputConfigCommand ?? true) && props.mastersRole;
    if (outputConfigCommand) {
      const postfix = commonCommandOptions.join(' ');
      new CfnOutput(this, 'ConfigCommand', { value: `${updateConfigCommandPrefix} ${postfix}` });
      new CfnOutput(this, 'GetTokenCommand', { value: `${getTokenCommandPrefix} ${postfix}` });
    }

Reproduction Steps

Set outputConfigCommand to true

Possible Solution

No response

Additional Information/Context

Seems to be broken in 51f0193

CDK CLI Version

2.171.0 (build 4957967)

Framework Version

No response

Node.js Version

20

OS

Mac

Language

TypeScript

Language Version

No response

Other information

No response

@markusl markusl added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Nov 28, 2024
@github-actions github-actions bot added potential-regression Marking this issue as a potential regression to be checked by team member @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service labels Nov 28, 2024
@pahud
Copy link
Contributor

pahud commented Nov 29, 2024

const outputConfigCommand = (props.outputConfigCommand ?? true) && props.mastersRole;

This was an intentional breaking change from #25473

@pahud pahud added p3 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Nov 29, 2024
@markusl
Copy link
Contributor Author

markusl commented Nov 29, 2024

@pahud yes, it seems to be an intentional change, but I cannot see why. Please at least document the behavior and add a warning if the flag is set to true without mastersRole

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. effort/small Small work item – less than a day of effort p3 potential-regression Marking this issue as a potential regression to be checked by team member
Projects
None yet
Development

No branches or pull requests

2 participants