Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aws-eks] Managed NodeGroups #5086

Closed
2 tasks
Tracked by #6491
pahud opened this issue Nov 19, 2019 · 1 comment · Fixed by #6759
Closed
2 tasks
Tracked by #6491

[aws-eks] Managed NodeGroups #5086

pahud opened this issue Nov 19, 2019 · 1 comment · Fixed by #6759
Assignees
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@pahud
Copy link
Contributor

pahud commented Nov 19, 2019

Amazon EKS announced the support for managed nodegroup today
https://aws.amazon.com/tw/blogs/containers/eks-managed-node-groups/

Use Case

To create the cluster with a default managed nodegroup.

Proposed Solution

// allocate default capacity if non-zero (or default).
const desiredCapacity = props.defaultCapacity === undefined ? DEFAULT_CAPACITY_COUNT : props.defaultCapacity;
if (desiredCapacity > 0) {
const instanceType = props.defaultCapacityInstance || DEFAULT_CAPACITY_TYPE;
this.defaultCapacity = this.addCapacity('DefaultCapacity', { instanceType, desiredCapacity });
}

Maybe we can replace this by adding a default managed nodegroup here

We also need to support --node-volume-size (like eksctl)

Other

AWS::EKS::NodeGroup - Managed Node Groups on EKS #264
aws-cloudformation/cloudformation-coverage-roadmap#264

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@pahud pahud added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 19, 2019
@SomayaB SomayaB added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Nov 19, 2019
@pahud
Copy link
Contributor Author

pahud commented Nov 22, 2019

CFN has native support for AWS::EKS::Nodegroup now.

And please note the new AWS::EKS::Cluster resource also updated and will return the ClusterSecurityGroupId attribute for the managed nodegroup.

aws-cloudformation/cloudformation-coverage-roadmap#264 (comment)

CFN resource reference

AWS::EKS::Cluster
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-eks-cluster.html

AWS::EKS::Nodegroup
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-eks-nodegroup.html

@eladb eladb added the effort/medium Medium work item – several days of effort label Jan 23, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Mar 5, 2020
@eladb eladb added the p1 label Mar 9, 2020
@eladb eladb changed the title aws-eks: create cluster with managed nodegroup eks: NodeGroups Mar 9, 2020
@eladb eladb changed the title eks: NodeGroups eks: Managed NodeGroups Mar 9, 2020
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Mar 19, 2020
@mergify mergify bot closed this as completed in #6759 Mar 25, 2020
mergify bot pushed a commit that referenced this issue Mar 25, 2020
feat(aws-eks): managed nodegroup support (#6759   )

BREAKING CHANGE: `Cluster` now creates a default managed nodegroup as its default capacity. Set the new cluster property `defaultCapacityType` to `DefaultCapacityType.EC2` to preserve `EC2` as its default capacity.

Closes #5086
@ccfife ccfife mentioned this issue Apr 8, 2020
19 tasks
@iliapolo iliapolo changed the title eks: Managed NodeGroups [aws-eks] Managed NodeGroups Aug 16, 2020
@iliapolo iliapolo removed the in-progress This issue is being actively worked on. label Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants