Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eks): Helm release name length & --wait option. #6276

Merged
merged 4 commits into from
Feb 18, 2020
Merged

fix(eks): Helm release name length & --wait option. #6276

merged 4 commits into from
Feb 18, 2020

Commits on Feb 18, 2020

  1. Fix Helm release name limit (53, not 63) 

    See: https://github.com/helm/helm/blob/b63822ed12de1badbb61736d2f7ea4e756ef757d/pkg/action/install.go#L52-L55
    @michaelmoussa
    michaelmoussa committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    cdc6253 View commit details
    Browse the repository at this point in the history

  2. Support asking Helm to wait for install to finish 

    Currently, Helm will not wait until all applicable resources are in a ready
state before deciding a release is successful and moving on. This can be
problematic for subsequent chart installations that will necessarily fail
if the previous has not completed, even if explicitly added as a dependency.
    @michaelmoussa
    michaelmoussa committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    59d489b View commit details
    Browse the repository at this point in the history

  3. Update integration test expectations

    @michaelmoussa
    michaelmoussa committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    db3a8bc View commit details
    Browse the repository at this point in the history

  4. Add test for --wait default

    @michaelmoussa
    michaelmoussa committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    301e522 View commit details
    Browse the repository at this point in the history