chore(ec2): convert tests to Jest #8811
Conversation
Turn the `aws-ec2` nodeunit test set into a Jest test set. In order to speed up the conversion, I did not actually rewrite the tests. Instead, I added a shim layer which converts between the two APIs. That means we're free to ditch the nodeunit dependency add future tests in Jest format, while spending minimal effort on the conversion.
| @@ -10,7 +10,7 @@ import { | |||
| Vpc, | |||
| } from '../lib'; | |||
|
|
|||
| export = { | |||
| nodeunitShim({ | |||
There was a problem hiding this comment.
Nit (don’t change anything!): I expected this to be called jestShim given it’s part of the nodeunit-shim module.
| import { AmazonLinuxImage, BlockDeviceVolume, EbsDeviceVolumeType, Instance, InstanceClass, InstanceSize, InstanceType, Vpc } from '../lib'; | ||
|
|
||
| export = { | ||
| nodeunitShim({ |
There was a problem hiding this comment.
Btw why do we need to wrap each test with this? A simple require of the test file and producing a jest test for each exported function should have done the trick. No?
So basically you could just added a single jest test file inside the test directory which would find all nodeunit tests and export them as jest tests.
There was a problem hiding this comment.
Potentially.
Though we'd also need to hook the require("nodeunit") call.
I'd encourage you to try to do it that way when you go to convert a module :)
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Following in the example of #8811 and the aws-ec2 conversion, converting the aws-cloudfront tests to Jest in preparation for adding new tests.
Following in the example of #8811 and the aws-ec2 conversion, converting the aws-cloudfront tests to Jest in preparation for adding new tests. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Turn the
aws-ec2nodeunit test set into a Jest test set.In order to speed up the conversion, I did not actually rewrite the
tests. Instead, I added a shim layer which converts between the two
APIs. That means we're free to ditch the nodeunit dependency add future
tests in Jest format, while spending minimal effort on the conversion.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license