{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":151767322,"defaultBranch":"master","name":"aws-ofi-nccl","ownerLogin":"aws","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2018-10-05T19:17:39.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/2232217?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1726102633.0","currentOid":""},"activityList":{"items":[{"before":"ae59bf230a34e4890d0c1140d004261c8c686310","after":"1acfebcdf7b21bd10140e7bace8209685ac9971e","ref":"refs/heads/master","pushedAt":"2024-09-24T17:59:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rajachan","name":"Raghu Raja","path":"/rajachan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/742736?s=80&v=4"},"commit":{"message":"Fully destroy endpoints when refcount is 0\n\nPrevious to this patch, endpoints were never freed, but just had most\nresources released when the ref count reached zero. This was because\nthe use of pthread thread specific data store meant that only the\nthread that created the ep could remove it from the thread specific\ndata store. Since we couldn't guarantee that, we never actually\nremoved data from the store.\n\nThis patch switches from pthread thread specific storage to using a\nhash table indexed by the thread id. Note that we use gettid() instead\nof pthread_self(), because pthread_t is a opaque structure that is not\ncomparable and so can't really be used as a hash key. If we want to\nsupport OSes other than Linux, then we can add more ways to get the\nunique thread id.\n\nSigned-off-by: Brian Barrett ","shortMessageHtmlLink":"Fully destroy endpoints when refcount is 0"}},{"before":"fba6e1b580983199c8474086f6885ce364bd94ac","after":"ae59bf230a34e4890d0c1140d004261c8c686310","ref":"refs/heads/master","pushedAt":"2024-09-24T17:06:09.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rauteric","name":"Eric Raut","path":"/rauteric","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/10216922?s=80&v=4"},"commit":{"message":"fix(m4): set redzone size to 0 (#616)\n\nWe were mistakenly adding redzones to our freelist entries in release\r\nbuilds due to an incorrect check for enabled memory checkers.\r\n\r\nSigned-off-by: Eric Raut ","shortMessageHtmlLink":"fix(m4): set redzone size to 0 (#616)"}},{"before":"497b22cdf5ddcee06c5e61322198dc51aff09ba4","after":"fba6e1b580983199c8474086f6885ce364bd94ac","ref":"refs/heads/master","pushedAt":"2024-09-24T17:03:53.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"rajachan","name":"Raghu Raja","path":"/rajachan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/742736?s=80&v=4"},"commit":{"message":".ci/aws: Add trainium tests to CI\n\nNightlies show that the trn1 lastest_release tests are stable on 8\nnodes, add this back in.\n\nSigned-off-by: Seth Zegelstein \n(cherry picked from commit 59bfaa40)","shortMessageHtmlLink":".ci/aws: Add trainium tests to CI"}},{"before":"159bfed1e0dc6d198b6006ef1bf4f47ef8b4d391","after":"497b22cdf5ddcee06c5e61322198dc51aff09ba4","ref":"refs/heads/master","pushedAt":"2024-09-23T21:34:20.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"a-szegel","name":"Seth Zegelstein","path":"/a-szegel","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/97712042?s=80&v=4"},"commit":{"message":".ci/aws: Unpin al2 p3dn ami\n\nThe al2 p3dn AMI was pinned to a manually created AMI by running\nPortaFiducia's setup_instances.py on a p3dn.24xlarge. In order to keep\nup to date with OS security updates, EC2 Image Builder is used to create\nnew updated AMI's daily. B/c p3dn is in short supply, EC2 Image Builder\nuses a g3 instance to generate the p3dn AMI. The AMI building script\nwas working successfully when run on p3dn. The same script when run on\ng3dn would run without issues, but would not generate an AMI with CUDA\ninstalled correctly (nvidia-smi wouldn't work). Recently, we were able\nto fix the bug in how we were installing CUDA in our AMI Builder, which\nallows us to unpin the p3dn AMI, and use the newest AMI with the latest\ngreatest security fixes.\n\nSigned-off-by: Seth Zegelstein ","shortMessageHtmlLink":".ci/aws: Unpin al2 p3dn ami"}},{"before":"cbf51155d6a16b405136571e12969980a42f92cf","after":"159bfed1e0dc6d198b6006ef1bf4f47ef8b4d391","ref":"refs/heads/master","pushedAt":"2024-09-20T14:11:08.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bwbarrett","name":"Brian Barrett","path":"/bwbarrett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15623965?s=80&v=4"},"commit":{"message":"Improve protocol selection logic\n\nChange the protocol selection logic when the platform file does\nnot specify a protocol. Instead of always defaulting to sendrecv\nif the user / platform file didn't specify a protocol, try to figure\nout when rdma is a good default. We still are conservative with\nenabling the rdma protocol, to avoid changing the default in as\nmany places as posible.\n\nWith the change, the protocol selection order is:\n\n 1. if the user set NCCL_OFI_PROTOCOL, use that.\n 2. if the platform init set nccl_ofi_selected_protocol, use that.\n 3. If the rdma protocol reports multiple nics per device and\n initialized successfully, use that.\n 4. If the sendrecv protocol initialized successfully, use that.\n 5. If the rdma protocol initialized successfully, use that.\n\nSigned-off-by: Brian Barrett ","shortMessageHtmlLink":"Improve protocol selection logic"}},{"before":"9e1892d0f8c89d15558c90d0db3b24ae85e84c13","after":"cbf51155d6a16b405136571e12969980a42f92cf","ref":"refs/heads/master","pushedAt":"2024-09-20T04:24:26.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"Fix log format string behavior\n\nGCC is willing to enforce printf-style format checks if the typedef\nfor the log function pointer is tagged with the appropriate attribute.\nClang behaves oddly, only generating warnings in the tests. Which is\nweird, but at least get warnings for GCC is a huge win.\n\nWith printf warning checks, we find many issues that are also fixed\nin this patch.\n\nSigned-off-by: Brian Barrett ","shortMessageHtmlLink":"Fix log format string behavior"}},{"before":"af6eb8f335304354357487689c6af0875c2a60bd","after":"9e1892d0f8c89d15558c90d0db3b24ae85e84c13","ref":"refs/heads/master","pushedAt":"2024-09-20T02:40:45.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"bwbarrett","name":"Brian Barrett","path":"/bwbarrett","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/15623965?s=80&v=4"},"commit":{"message":"util: Use FI_ENOPROTOOPT to check for a provider's support for option\n\nfi_endpoint(3) states that fi_setopt/_getopt calls return FI_ENOPROTOOPT\nwhen a provider does not support a requested option. Certain setopt\noptions also return FI_EOPNOTSUPP if a particular mode forced by setting\nan option is not supported (such as, with FI_OPT_CUDA_API_PERMITTED\nbeing set to false when a provider requires CUDA API to support\nFI_HMEM_CUDA). Checking for both as we have the same error\noutcome in either case.\n\nFixes #606\n\nSigned-off-by: Raghu Raja ","shortMessageHtmlLink":"util: Use FI_ENOPROTOOPT to check for a provider's support for option"}},{"before":"83f563cf795d59abf5fad986c31516ef4e41cbaf","after":"af6eb8f335304354357487689c6af0875c2a60bd","ref":"refs/heads/master","pushedAt":"2024-09-19T20:18:08.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"rajachan","name":"Raghu Raja","path":"/rajachan","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/742736?s=80&v=4"},"commit":{"message":"ci: Drop the use of cache-apt-pkgs-action\n\nOne less third-party action dependency.\n\nSigned-off-by: Raghu Raja ","shortMessageHtmlLink":"ci: Drop the use of cache-apt-pkgs-action"}},{"before":"653a4d74bdfe5347c07a75514a9766862070c6c4","after":"83f563cf795d59abf5fad986c31516ef4e41cbaf","ref":"refs/heads/master","pushedAt":"2024-09-19T13:00:13.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"feat(ci/github): use docker instead of codebuild\n\ncodebuild runners seems to get stuck for us regularly for whatever\nreason, just use docker and the al2023/al2 images that exist there.\nOther fixes: use the amzn2023 cuda repo, bump cuda versions that these\nbuilds operate against.\n\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"feat(ci/github): use docker instead of codebuild"}},{"before":"d459367d6038d2fc902a633535e5d4be3a671a33","after":"653a4d74bdfe5347c07a75514a9766862070c6c4","ref":"refs/heads/master","pushedAt":"2024-09-18T19:09:37.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(valgrind): fix autotools mistake (#607)\n\nAC_LANG_PROGRAM creates main for you, so putting `int main(void)` fails\r\nthe check due to warnings, even when the header is available.\r\n\r\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"fix(valgrind): fix autotools mistake (#607)"}},{"before":"fa02047071c685279015166aaa63c091482c35fd","after":"0dace6a1f166c13d1a7a0eacfbd58a84c9b0c6fb","ref":"refs/heads/aws-nslick/stack/29","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(test): fix typing issues\n\nSigned-off-by: Nicholas Sielicki \n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/587, branch: aws-nslick/stack/29","shortMessageHtmlLink":"fix(test): fix typing issues"}},{"before":"a4650f521b0738e071d6d4c5e771b53ec79989e2","after":"201ec509ce6764f5154ae38fa766a30f0dacebc0","ref":"refs/heads/aws-nslick/stack/31","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(build): check features before mangling CFLAGS\n\nYet another autotools fix: If any warning/devel CFLAGS would invoke\nwarnings in headers used to detect dependencies, those dependencies will\nfail with a highly misleading/confusing error message:\n\n> configure: Found .git directory. Adding -Werror to CFLAGS.\n> checking if running on EC2 instance... yes\n> checking if want AWS platform optimizations... yes\n> checking for Libfabric 1.18.0 or later... no\n> configure: error: On AWS platforms, Libfabric 1.18.0 or later is required\n\nie: it is not that Libfabric 1.18 was not found, it was that its headers\nproduced warnings. Fix this by resolving all dependencies before\nmodifying CFLAGS.\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/589, branch: aws-nslick/stack/31","shortMessageHtmlLink":"fix(build): check features before mangling CFLAGS"}},{"before":"723345e3e40b05b49d137d6d60e06c8c00116aa8","after":"23adfcf0786215c21730f626907e95790991f111","ref":"refs/heads/aws-nslick/stack/16","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(tuner): avoid gotos\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/569, branch: aws-nslick/stack/16\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"fix(tuner): avoid gotos"}},{"before":"d76970970219c04b85598287bea456b0ee1292e8","after":"34c8a0968556d69a90c8fbf23b7e0178ef272bbc","ref":"refs/heads/aws-nslick/stack/10","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(tree): move declarations to top of function\n\nc++ suppoorts initializers anywhere in the function, but one must not\njump over an initializer with any goto usage. Given the lack of RAII in\nC, this becomes a significant painpoint.\n\nIn large to-be-eventually-refactored functions contain gotos or use\nswitch statements, split declaration and initialization, and move all\ndeclarations to the top of the function. This makes switch statements\nand gotos safe in both languages.\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/563, branch: aws-nslick/stack/10\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"fix(tree): move declarations to top of function"}},{"before":"9250d50f278e2e5574780220479737c6827aa040","after":"3f8927a94bb747debe64db5e05fcea2bb8b7d261","ref":"refs/heads/aws-nslick/stack/13","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"chore(build): add AC_PROG_CXX\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/566, branch: aws-nslick/stack/13\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"chore(build): add AC_PROG_CXX"}},{"before":"68750ac67d36d88cca6b6e66864297c6a75788e5","after":"48ffcb6c7ec6ba3ffe9607beb1fd1f8b02cef434","ref":"refs/heads/aws-nslick/stack/32","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"feat(rdma): constrain C linkage to init\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/591, branch: aws-nslick/stack/32","shortMessageHtmlLink":"feat(rdma): constrain C linkage to init"}},{"before":"03c499438bc1c7e1fd0e6c66a6c1b609aea6c33e","after":"53ceba28f1ce9f0878aae2323d05893b87535c38","ref":"refs/heads/aws-nslick/stack/30","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"feat(build): add -Wextra to \"picky\" compiler flags\n\nSigned-off-by: Nicholas Sielicki \n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/588, branch: aws-nslick/stack/30","shortMessageHtmlLink":"feat(build): add -Wextra to \"picky\" compiler flags"}},{"before":"822a8e2a1a0eaba02b6e9289f9b5debdd59f345a","after":"5958f98dbb419bca743968cf8db60cee2b0d902e","ref":"refs/heads/aws-nslick/stack/34","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(tracing/nvtx): silence -Wmissing-field-initializer warnings\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/593, branch: aws-nslick/stack/34","shortMessageHtmlLink":"fix(tracing/nvtx): silence -Wmissing-field-initializer warnings"}},{"before":"54cff5b5ff475918f1bfc4914d147f81ae896df4","after":"6981153c684dc06fb46f9b058d87ab6dac1deb10","ref":"refs/heads/aws-nslick/stack/36","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(platform-aws): fill all platform values\n\ncommit ce214aa rearranged fields such that the written initializers were\nvalid on most modern compilers, but it went unnoticed that this is\ninsufficient for AL2's ancient toolchain, which fails with:\n\n> sorry, unimplemented: non-trivial designated initializers not supported\n\nprovide all members for all entries to fix this.\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/595, branch: aws-nslick/stack/36","shortMessageHtmlLink":"fix(platform-aws): fill all platform values"}},{"before":"4d8407228598399a4bf8418688fa056496eb4ee1","after":"7d62b0fc8f7204b5116d883cd91062cbc3a49f7a","ref":"refs/heads/aws-nslick/stack/24","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(neuron): remove const from ncclNetPlugin_v{4,5} syms\n\nconst variables have internal linkage by default under c++; nvidia\ninterface requires it not be const because its modified during init.\nRemove const for neuron, too.\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/577, branch: aws-nslick/stack/24\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"fix(neuron): remove const from ncclNetPlugin_v{4,5} syms"}},{"before":"6b9309a71d2b65dc82964272ab23e5620e25587c","after":"7fd55d0b06d1d1f2a020c37043182a4d7cb5ea1c","ref":"refs/heads/aws-nslick/stack/35","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(tree): use empty brace initializers for zero-initialization\n\nprefer `struct foo bar = {}' to `struct foo bar = { 0 }' to avoid\n-Wmissing-field-initializers warnings.\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/594, branch: aws-nslick/stack/35","shortMessageHtmlLink":"fix(tree): use empty brace initializers for zero-initialization"}},{"before":"dac63aed35c84a27bfe53d7ff12444e45390a610","after":"93206c340c3340d364cf8f6143869cf5e6eaab9c","ref":"refs/heads/aws-nslick/stack/12","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(tree): use decltype instead of typeof for cxx\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/565, branch: aws-nslick/stack/12\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"fix(tree): use decltype instead of typeof for cxx"}},{"before":"1e2610e91ac8fab3f4cd67a29caa372fb43bc156","after":"994f5dc2f0df1ec4bb4d8072d9ad1aa69427af5f","ref":"refs/heads/aws-nslick/stack/22","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(tree): avoid sign comparison issues\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/575, branch: aws-nslick/stack/22\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"fix(tree): avoid sign comparison issues"}},{"before":"0f45396e1da6afc46848ca859c793a6eab766daf","after":"a06ae92cd68f385ce031de88c267d8ad358b6d69","ref":"refs/heads/aws-nslick/stack/21","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(rdma): use COMM_ID_MASK as invalid id\n\nPreviously, this used ~0 as the invalid signal. This defaults to a\nsigned type, which breaks under -wsign-compare. Prefer to use\nCOMM_ID_MASK as the marker.\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/574, branch: aws-nslick/stack/21\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"fix(rdma): use COMM_ID_MASK as invalid id"}},{"before":"7617166297601b2320ee233776a506c9041d1800","after":"a1c3e2780e3b89d3579118a7b9de99ff87d17472","ref":"refs/heads/aws-nslick/stack/17","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"feat(param): add uint parameter macro\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/570, branch: aws-nslick/stack/17\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"feat(param): add uint parameter macro"}},{"before":"4dfed3be705b0163eb1d596dff78a8a27dd3d751","after":"b44404f3bd8f485b13d60c03295165e79f3410d0","ref":"refs/heads/aws-nslick/stack/27","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(tree): add fallthrough switch markers\n\nSigned-off-by: Nicholas Sielicki \n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/585, branch: aws-nslick/stack/27","shortMessageHtmlLink":"fix(tree): add fallthrough switch markers"}},{"before":"333cefd9f13554008e9eddee9a679cbeb86de886","after":"b9bb438905273dcb1b076dda084131d3e7164fe9","ref":"refs/heads/aws-nslick/stack/23","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(sendrecv): add missing nccl-headers include\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/576, branch: aws-nslick/stack/23\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"fix(sendrecv): add missing nccl-headers include"}},{"before":"c4eea60a91f6684392c676f9c3031690354ae046","after":"d4b3764c67096f2a32d75a19cbe041f8eb5ae123","ref":"refs/heads/aws-nslick/stack/20","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(tuner): fix implicit conversions\n\ncpp requires explicit cast to double here.\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/573, branch: aws-nslick/stack/20\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"fix(tuner): fix implicit conversions"}},{"before":"3c7c3212b1298f004d1ca9a507d97a6c51c689ae","after":"d8a1b661ba15bc3800453c9c096ef645c5032c68","ref":"refs/heads/aws-nslick/stack/14","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"chore(build): mpi: set mpicxx, too.\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/567, branch: aws-nslick/stack/14\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"chore(build): mpi: set mpicxx, too."}},{"before":"e4832c9a509fa7f1d6ee6aba3af067936d596651","after":"da89e976118621200b58fd1ecc443c04c1113cb4","ref":"refs/heads/aws-nslick/stack/18","pushedAt":"2024-09-17T20:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"aws-nslick","name":"Nicholas Sielicki","path":"/aws-nslick","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/145174695?s=80&v=4"},"commit":{"message":"fix(param): move some parameters to unsigned\n\nmr_key_size and eager_max_size are positive integers, avoid sign\ncomparison issues by treating them as such.\n\nstack-info: PR: https://github.com/aws/aws-ofi-nccl/pull/571, branch: aws-nslick/stack/18\nSigned-off-by: Nicholas Sielicki ","shortMessageHtmlLink":"fix(param): move some parameters to unsigned"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yNFQxNzo1OTo0NS4wMDAwMDBazwAAAAS_eU5A","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0xN1QyMDoyNTozNy4wMDAwMDBazwAAAAS49aIv"}},"title":"Activity ยท aws/aws-ofi-nccl"}