Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lock kernel minor version during image build #6624

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

hgreebe
Copy link
Contributor

@hgreebe hgreebe commented Dec 13, 2024

Description of changes

  • Lock kernel minor version during image build

Tests

  • Ran first_stage_build for rhel9

Please review the guidelines for contributing and Pull Request Instructions.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@hgreebe hgreebe requested review from a team as code owners December 13, 2024 18:38
@hanwen-cluster hanwen-cluster added the skip-changelog-update Disables the check that enforces changelog updates in PRs label Dec 13, 2024
@hanwen-cluster hanwen-cluster enabled auto-merge (rebase) December 13, 2024 21:31
Copy link

@hanwen-cluster hanwen-cluster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To speed up development, I will approve this PR. More improvements are needed:

  1. krb5-lib upgrade is not necessary
  2. we should only remove minor version pinning if the pin was done by us. A easy approach is to write/read a file under /opt/parallelcluster/ to indicate if the pin is done by us
  3. I am not sure we should pin the minor version in update and reboot. This is a behavioral change to UpdateOsPackages parameter

@hanwen-cluster hanwen-cluster merged commit f554851 into aws:release-3.12 Dec 13, 2024
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog-update Disables the check that enforces changelog updates in PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants