feat(integ): add ability to use hook function before each component test #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jusiskin
requested changes
Oct 7, 2020
integ/scripts/bash/rfdk-integ-e2e.sh
Outdated
| @@ -71,6 +71,12 @@ export INFRASTRUCTURE_DEPLOY_FINISH_TIME=$SECONDS | |||
|
|
|||
| # Pull the top level directory for each cdk app in the components directory | |||
| for COMPONENT in **/cdk.json; do | |||
| # Invoke hook function if it is exported and name is defined in HOOK_FUNCTION variable | |||
| if [ -n "$HOOK_FUNCTION" ] && [ "$(type -t $HOOK_FUNCTION)" == "function" ] | |||
There was a problem hiding this comment.
How would you feel about using a more descriptive variable name? Say PRE_COMPONENT_HOOK?
integ/scripts/bash/rfdk-integ-e2e.sh
Outdated
| # Invoke hook function if it is exported and name is defined in HOOK_FUNCTION variable | ||
| if [ -n "$HOOK_FUNCTION" ] && [ "$(type -t $HOOK_FUNCTION)" == "function" ] | ||
| then | ||
| $HOOK_FUNCTION |
There was a problem hiding this comment.
Is there any argument/parameters that might be useful to pass to the hook function? I'm trying to think in the general case if someone would need a hook function that is triggered before each component test, they'd likely be interested in knowing which component is being tested. Does it make sense to include the component name?
|
Can we scope the conventional commit title to |
jusiskin
changed the title
kozlove-aws
force-pushed
the
add_use_hook_function
branch
from
43c013e
to
c039a10
Compare
jusiskin
approved these changes
Oct 7, 2020
ddneilson
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In the main integ-rfdk-e2e.sh we need to add the ability to run an extra function if it is designed.
Solution
Added functionality to invoke script in case when environment variable
PRE_COMPONENT_HOOKis defined and function with such name was exported.Testing
Script was tested locally with all cases like: correct function, undefined variable or function name is incorrect.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license