Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(integ): fix when PRE_COMPONENT_HOOK is undefined #166

Merged
merged 1 commit into from
Oct 9, 2020

Conversation

horsmand
Copy link
Contributor

@horsmand horsmand commented Oct 9, 2020

Fixes a bug where we were referencing the environment variable PRE_COMPONENT_HOOK in a way that would fail if it were unassigned.

The integration tests were failing during start-up without this fix. They are now able to run with the fix applied.

Fixes #164


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Fixes a bug where we were referencing the environment variable
PRE_COMPONENT_HOOK in a way that would fail if it were unassigned.

Fixes #164
@horsmand horsmand added the contribution/core This is a PR that came from AWS. label Oct 9, 2020
Copy link
Contributor

@ddneilson ddneilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching & fixing this oversight, David.

@jusiskin jusiskin changed the title fix(integ): Fixed rfdk-integ-e2e.sh fix(integ): fix when PRE_COMPONENT_HOOK is undefined Oct 9, 2020
@jusiskin jusiskin merged commit b4bfd4e into aws:mainline Oct 9, 2020
@horsmand horsmand mentioned this pull request Oct 13, 2020
@horsmand horsmand deleted the integ-hook-fix branch October 13, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration tests failing during start-up
3 participants