Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deadline): allow providing subnets for RenderQueue's ALB #264

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

ddneilson
Copy link
Contributor

Implements: #263


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@horsmand horsmand added the contribution/core This is a PR that came from AWS. label Dec 8, 2020
@ddneilson ddneilson linked an issue Dec 11, 2020 that may be closed by this pull request
2 tasks
horsmand
horsmand previously approved these changes Dec 18, 2020
horsmand
horsmand previously approved these changes Jan 5, 2021
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor prop rename suggestion - otherwise looks good

packages/aws-rfdk/lib/deadline/lib/render-queue-ref.ts Outdated Show resolved Hide resolved
@jusiskin jusiskin changed the title feat(deadline): Allow providing subnets for RenderQueue's ALB feat(deadline): allow providing subnets for RenderQueue's ALB Jan 5, 2021
@jusiskin jusiskin merged commit 53088fb into aws:mainline Jan 5, 2021
@ddneilson ddneilson deleted the fix_single_az_alb branch March 17, 2021 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow subnet selection for RenderQueue's ALB
3 participants