fix(core): move mountable's asset to scope of target #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're unable to update the mountable's scripts without a full tear-down of all consuming stacks. This moves the assets to the target's stack instead of the Mountable's stack to avoid exports in cross-stack usage. BREAKING CHANGE: Stacks set up like our examples will see an error regarding being unable to delete an export in use when deploying a stack update. To bypass, use cdk deploy's -e option to deploy each stack upstream of the Mountable's stack before updating the Mountable's stack. e.g. - cdk deploy -e ComputeTier; cdk deploy -e ServiceTier; cdk deploy -e StorageTier
jericht
approved these changes
Mar 31, 2021
jusiskin
approved these changes
Mar 31, 2021
jusiskin
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're unable to update the mountable's scripts without a full tear-down of all consuming stacks.
This moves the assets to the target's stack instead of the Mountable's stack to avoid exports in
cross-stack usage.
BREAKING CHANGE: Stacks set up like our examples will see an error regarding being unable to
delete an export in use when deploying a stack update. To bypass, use cdk deploy's -e option
to deploy each stack upstream of the Mountable's stack before updating the Mountable's stack. e.g.
Fixes: #368
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license