Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deadline): allow zero-sized WorkerInstanceFleet #451

Merged
merged 2 commits into from
May 27, 2021
Merged

fix(deadline): allow zero-sized WorkerInstanceFleet #451

merged 2 commits into from
May 27, 2021

Conversation

ddneilson
Copy link
Contributor

Fixes: #442

Testing

  • Deployed the all-in basic example with worker fleet min capacity of 0 and 1. Both successful.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jusiskin jusiskin self-requested a review May 27, 2021 22:00
jusiskin
jusiskin approved these changes May 27, 2021
View reviewed changes
Copy link
Contributor

@jusiskin jusiskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Just a little testing advice for the future, but I'm fine with merging this as-is.

packages/aws-rfdk/lib/deadline/test/worker-fleet.test.ts Show resolved Hide resolved
@jusiskin jusiskin merged commit 0cc6723 into aws:mainline May 27, 2021
@ddneilson ddneilson deleted the allow_zero_size_fleets branch July 28, 2022 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jericht jericht jericht approved these changes

@jusiskin jusiskin jusiskin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

On-Demand worker fleets time out during deployment if min_capacity is set to 0
3 participants
@ddneilson @jusiskin @jericht