Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Convert group & pool names in SpotEventPluginFleet to lowercase #465

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

kozlove-aws
Copy link
Contributor

@kozlove-aws kozlove-aws commented Jun 11, 2021

Problem

Groups & pools are always lowercase in Deadline.
The SpotEventPluginFleet is passing the Group/Pool names through as given, without ensuring that they are in lower case. With the SpotEventPluginFleet currently not creating the required groups, this means that it is impossible for a customer to create the required group on their own if they ask for one that has uppercase characters in it.

Solution

  • Convert group and pool names lo lowercase
  • Changed validation for group names

Testing

  • Deployed farm with group and pool that names contain capital symbols.
  • Verified that spot configuration deployed with converted group name.
  • Created pool and group with lowercase names and send a job with this pool and group.
  • Make sure that worker was spawned and rendered this job.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@jusiskin jusiskin added the contribution/core This is a PR that came from AWS. label Jun 11, 2021
ddneilson
ddneilson previously approved these changes Jun 14, 2021
Copy link
Contributor

@jericht jericht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one tiny comment otherwise this looks great!

@jusiskin jusiskin linked an issue Jun 22, 2021 that may be closed by this pull request
@ddneilson ddneilson merged commit 11e30f6 into aws:mainline Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SpotEventPluginFleet must lowercase group & pool names
4 participants