fix(core): Convert group & pool names in SpotEventPluginFleet to lowercase #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Groups & pools are always lowercase in Deadline.
The SpotEventPluginFleet is passing the Group/Pool names through as given, without ensuring that they are in lower case. With the SpotEventPluginFleet currently not creating the required groups, this means that it is impossible for a customer to create the required group on their own if they ask for one that has uppercase characters in it.
Solution
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license