Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow setting BaseEndpoint on config.LoadOptions #2422

Closed
1 of 2 tasks
gdavison opened this issue Dec 11, 2023 · 2 comments · Fixed by #2837
Closed
1 of 2 tasks

Allow setting BaseEndpoint on config.LoadOptions #2422

gdavison opened this issue Dec 11, 2023 · 2 comments · Fixed by #2837
Assignees
@lucix-aws
Labels
feature-request A feature should be added or improved. p1 This is a high priority issue v1-v2-inconsistency v1-v2-inconsistency Behavior has changed from v1 to v2, or feature is missing altogether

Comments

@gdavison
Copy link
Contributor

Describe the feature

The config.SharedConfig and config.EnvConfig structs both have a parameter BaseEndpoint that sets a common endpoint URL for all services. config.LoadOptions does not have the corresponding parameter.

Also add the corresponding config.WithBaseEndpoint functional option.

Use Case

While an endpoint resolver could be configured with a base endpoint, adding BaseEndpoint would make a more consistent interface, as well as allowing the SDK to handle the override logic including service-specific endpoints and ignoring configured endpoints.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Go SDK V2 Module Versions Used

github.com/aws/aws-sdk-go-v2 v1.24.0
github.com/aws/aws-sdk-go-v2/config v1.26.1

Go version used

go version go1.21.0 darwin/arm64
@gdavison gdavison added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 11, 2023
@gdavison gdavison mentioned this issue Dec 11, 2023
Open
@lucix-aws lucix-aws added p3 This is a minor priority issue queued This issues is on the AWS team's backlog and removed needs-triage This issue or PR still needs to be triaged. labels Dec 11, 2023
@gdavison gdavison mentioned this issue Dec 11, 2023
Closed
@lucix-aws lucix-aws added p1 This is a high priority issue and removed p3 This is a minor priority issue labels Oct 11, 2024
@lucix-aws lucix-aws self-assigned this Oct 11, 2024
@lucix-aws
Copy link
Contributor

I've identified this as a major migration blocker across the broader set of SDK use cases. Increasing priority.

@lucix-aws lucix-aws added the v1-v2-inconsistency v1-v2-inconsistency Behavior has changed from v1 to v2, or feature is missing altogether label Oct 11, 2024
This was referenced Oct 11, 2024
Open
Merged
@lucix-aws lucix-aws removed the queued This issues is on the AWS team's backlog label Oct 15, 2024
@github-actions GitHub Actions
Copy link

This issue is now closed. Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucix-aws lucix-aws

Labels
feature-request A feature should be added or improved. p1 This is a high priority issue v1-v2-inconsistency v1-v2-inconsistency Behavior has changed from v1 to v2, or feature is missing altogether
Projects
None yet
Milestone
No milestone
2 participants
@gdavison @lucix-aws