Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use exact @aws-sdk/* dependencies #1110

Merged
merged 4 commits into from
Apr 27, 2020

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Apr 27, 2020

Issue #, if available:
Replacement to #1108 for one-off beta.5 release to unblock Amplify

Description of changes:
use exact @aws-sdk/* dependencies

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

trivikr added 4 commits April 27, 2020 02:32
Search key: "@aws-sdk/([^"]*)": "\^1.0.0-beta.([\d])”
Replace key: "@aws-sdk/$1": "1.0.0-beta.$2"
in package.json
command run from another workspace:
find . -type f -name "package.json" -exec cp {} ~/workspace/aws-sdk-js-v3/{} \;
Search key: "@aws-sdk/([^"]*)": "\^1.0.0-beta.([\d])”
Replace key: "@aws-sdk/$1": "1.0.0-beta.$2"
in package.json
Copy link
Contributor

@AllanZhengYP AllanZhengYP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SHIP IT!

@trivikr
Copy link
Member Author

trivikr commented Apr 27, 2020

Confirmed that integration tests are successful when run locally:

$ yarn && yarn build:all
$ AWS_PROFILE=<teamProfile> yarn test:integration
yarn run v1.22.4

...
...

153 scenarios (153 passed)
531 steps (531 passed)
Done in 63.18s.

@aws-sdk-js-automation
Copy link

AWS CodeBuild CI Report

  • CodeBuild project: sdk-staging-test
  • Commit ID: 3826a15
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@trivikr
Copy link
Member Author

trivikr commented Apr 27, 2020

Test publish commit using lerna version --exact in trivikr@4b33a0e

Verified that packages of the versions updated were exact.

Command run for creating GitHub release commit:

./node_modules/lerna/cli.js version --exact --bump prerelease --preid beta --conventional-commits --no-push --no-git-tag-version --no-commit-hooks --yes

@trivikr trivikr merged commit bcfd7a2 into aws:one-off-beta-5 Apr 27, 2020
@trivikr trivikr deleted the one-off-beta-5-package-json branch April 27, 2020 03:35
@lock
Copy link

lock bot commented May 5, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants