Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant variables from ResponseMetadata #1465

Closed
trivikr opened this issue Aug 25, 2020 · 2 comments
Closed

Remove redundant variables from ResponseMetadata #1465

trivikr opened this issue Aug 25, 2020 · 2 comments
Labels
feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Aug 25, 2020

Is your feature request related to a problem? Please describe.
ResponseMetadata may contain redundant variables (requestId, extendedRequestId and cfId) which are present in httpHeaders

/**
* A unique identifier for the last request sent for this operation. Often
* requested by AWS service teams to aid in debugging.
*/
requestId?: string;
/**
* A secondary identifier for the last request sent. Used for debugging.
*/
extendedRequestId?: string;
/**
* A tertiary identifier for the last request sent. Used for debugging.
*/
cfId?: string;

Findings:

Describe the solution you'd like
Delete these redundant variables requestId, extendedRequestId and cfId

Additional context
This issue was cut while creating logger for v3

@trivikr trivikr added the feature-request New feature or enhancement. May require GitHub community feedback. label Aug 25, 2020
@trivikr
Copy link
Member Author

trivikr commented Sep 14, 2020

The keys extendedRequestId and cfId are important for debugging and will be added in #1521

Post that, the httpHeaders will be removed from metadata in #1491

@trivikr trivikr closed this as completed Sep 14, 2020
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Development

No branches or pull requests

1 participant