-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client-*): update endpoint provider #1824
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1824 +/- ##
==========================================
- Coverage 79.77% 79.30% -0.48%
==========================================
Files 325 368 +43
Lines 12087 15132 +3045
Branches 2553 3222 +669
==========================================
+ Hits 9643 12001 +2358
- Misses 2444 3131 +687
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! But requesting changes to delete VSCode Settings file.
* generate endpoint from the EndpointPrefix trait introduced in Smithy 1.5.0 * update all the endpoint.ts as of 2020/12/21
16aa088
to
56a2104
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Fixes #1817
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.