Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clients): use optional chaining while processing runtime config #2690

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

gosar
Copy link
Contributor

@gosar gosar commented Aug 19, 2021

Related to smithy-lang/smithy-typescript#401

Testing

How was this change tested?


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@gosar
Copy link
Contributor Author

gosar commented Aug 19, 2021

I think the tests are failing here because smithy-lang/smithy-typescript#401 needs to be merged for it to succeed.

@gosar gosar requested a review from AllanZhengYP August 19, 2021 19:39
@gosar gosar force-pushed the runtimeconfig-chaining branch from b80a3a8 to 6c436ed Compare August 20, 2021 18:02
@codecov-commenter
Copy link

codecov-commenter commented Aug 20, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@c7350f8). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head fb87032 differs from pull request most recent head fc40027. Consider uploading reports for the commit fc40027 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2690   +/-   ##
=======================================
  Coverage        ?   60.81%           
=======================================
  Files           ?      531           
  Lines           ?    27890           
  Branches        ?     6843           
=======================================
  Hits            ?    16960           
  Misses          ?    10930           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7350f8...fc40027. Read the comment docs.

@gosar gosar force-pushed the runtimeconfig-chaining branch from 6c436ed to fb87032 Compare August 23, 2021 18:33
gosar added 2 commits August 23, 2021 12:13
Using optional chaining `?.` instead of defaulting to `{}`.
…econfig generator

Using alternate solution of `?.` instead of defaulting to `{}`.
@gosar gosar force-pushed the runtimeconfig-chaining branch from fb87032 to fc40027 Compare August 23, 2021 19:18
@gosar gosar changed the title chore(clients): regenerate clients with modified runtimeconfig generator chore(clients): regenerate clients using optional chaining for runtimeconfig generator Aug 23, 2021
@trivikr trivikr changed the title chore(clients): regenerate clients using optional chaining for runtimeconfig generator chore(clients): use optional chaining while processing runtime config Aug 23, 2021
@trivikr trivikr changed the title chore(clients): use optional chaining while processing runtime config fix(clients): use optional chaining while processing runtime config Aug 23, 2021
@trivikr trivikr merged commit 18469ce into aws:main Aug 23, 2021
@gosar gosar deleted the runtimeconfig-chaining branch September 2, 2021 18:00
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants