-
Notifications
You must be signed in to change notification settings - Fork 585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(clients): move source files to 'src' folder #2845
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 29, 2021
for dir in ./clients/*; do (cd "$dir" && rm -rf *.ts commands models pagination protocols waiters); done for dir in ./protocol_tests/*; do (cd "$dir" && rm -rf *.ts commands models pagination protocols waiters tests); done
foreach parentDir ("clients" "protocol_tests") for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/\/dist\//\/dist-*/g' ./.gitignore); done for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/runtimeConfig/dist-es\/runtimeConfig/g' ./package.json); done for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/dist\//dist-/g' ./package.json); done for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/dist\//dist-/g' ./tsconfig.*); done for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/"outDir"/"rootDir":"src","outDir"/' ./tsconfig.json); done for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/^}$/,"exclude": ["test\/**\/*"]}/' ./tsconfig.json); done for dir in ./$parentDir/*; do (cd "$dir" && sed -i 's/^}$/,"exclude": ["test\/**\/*", "dist-types\/**\/*"]}/' ./tsconfig.types.json); done end
trivikr
force-pushed
the
client-src-final
branch
from
September 29, 2021 17:44
c46bb0b
to
bffb5a2
Compare
AllanZhengYP
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Cleaned up all the mess in our published package 🧹
This was referenced Sep 29, 2021
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Fixes: #1306
Note:
This PR would be rebased from main after #2844 is merged.PR is ready for review!Description
Moves source files in clients to 'src' folder
Testing
✅ CI is successful.
✅ Integration tests are successful.
yarn test:integration
yarn test:integration-legacy
✅ Mocha unit tests are successful.
ToDo after merge: DryRun release after merging this PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.