Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break generate-clients script to multiple modular commands #2953

Closed
trivikr opened this issue Oct 28, 2021 · 2 comments
Closed

Break generate-clients script to multiple modular commands #2953

trivikr opened this issue Oct 28, 2021 · 2 comments
Labels
closed-for-staleness feature-request New feature or enhancement. May require GitHub community feedback. p2 This is a standard priority issue

Comments

@trivikr
Copy link
Member

trivikr commented Oct 28, 2021

Is your feature request related to a problem? Please describe.

The generate-clients folder has a monolith code which does lot of things:

  • generates clients.
  • generates server artifacts if particular option is set.
  • generates private clients by default, but does not generate them when particular option is set.

When a new command to generate generic client had to be added, we have to write a duplicate script in #2952

Describe the solution you'd like

Refactor generate-clients folder to split into multiple commands, each one of which serves a different purpose. The parent command will call modular commands based on options passed.

Describe alternatives you've considered

  • Writing a new file per specific requirement.
  • Adding more code to monolith generate-clients script

Additional context

Advanced topics in yargs https://github.com/yargs/yargs/blob/main/docs/advanced.md

@trivikr trivikr added the feature-request New feature or enhancement. May require GitHub community feedback. label Oct 28, 2021
@ajredniwja ajredniwja added the p2 This is a standard priority issue label Oct 13, 2022
@github-actions
Copy link

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Oct 14, 2023
Copy link

github-actions bot commented Nov 2, 2023

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
closed-for-staleness feature-request New feature or enhancement. May require GitHub community feedback. p2 This is a standard priority issue
Projects
None yet
Development

No branches or pull requests

2 participants