Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RestJson tests are failing for server protocols #3058

Closed
trivikr opened this issue Nov 23, 2021 · 4 comments · Fixed by smithy-lang/smithy#993
Closed

RestJson tests are failing for server protocols #3058

trivikr opened this issue Nov 23, 2021 · 4 comments · Fixed by smithy-lang/smithy#993
Labels
bug This issue is a bug. closed-for-staleness p2 This is a standard priority issue

Comments

@trivikr
Copy link
Member

trivikr commented Nov 23, 2021

Describe the bug

RestJson tests are failing for server protocols.

Your environment

SDK version number

main

Is the issue in the browser/Node.js/ReactNative?

N/A

Details of the browser/Node.js/ReactNative version

N/A

Steps to reproduce

Observed behavior

Server protocol tests fail with the following error:

  ● RestJsonTestPayloadStructure:ServerRequest

    expect(received).toBeDefined()

    Received: undefined

      29065 |   ][0];
      29066 |   Object.keys(paramsToValidate).forEach((param) => {
    > 29067 |     expect(r[param]).toBeDefined();
            |                      ^
      29068 |     expect(equivalentContents(r[param], paramsToValidate[param])).toBe(true);
      29069 |   });
      29070 | });

      at test/functional/restjson1.spec.ts:29067:22
          at Array.forEach (<anonymous>)
      at Object.<anonymous> (test/functional/restjson1.spec.ts:29066:33)

  ● RestJsonHttpWithHeadersButNoPayload:ServerRequest

    expect(received).toBeDefined()

    Received: undefined

      29109 |   ][0];
      29110 |   Object.keys(paramsToValidate).forEach((param) => {
    > 29111 |     expect(r[param]).toBeDefined();
            |                      ^
      29112 |     expect(equivalentContents(r[param], paramsToValidate[param])).toBe(true);
      29113 |   });
      29114 | });

      at test/functional/restjson1.spec.ts:29111:22
          at Array.forEach (<anonymous>)
      at Object.<anonymous> (test/functional/restjson1.spec.ts:29110:33)

Test Suites: 1 failed, 1 total
Tests:       2 failed, 14 skipped, 684 passed, 700 total
Snapshots:   0 total
Time:        17.936 s
Ran all test suites.
error Command failed with exit code 1.

Expected behavior

RestJSON server protocol tests are successful

Additional context

Failures while bumping smithy to 1.14.x

@trivikr
Copy link
Member Author

trivikr commented Nov 24, 2021

The server protocol tests are still failing
#3062

@trivikr trivikr reopened this Nov 24, 2021
@github-actions
Copy link

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Nov 25, 2022
@trivikr trivikr removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Nov 25, 2022
@RanVaknin RanVaknin added the p2 This is a standard priority issue label Feb 9, 2023
Copy link

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Feb 10, 2024
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug This issue is a bug. closed-for-staleness p2 This is a standard priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants