Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move @types/node devDependency to root package.json #3142

Closed
trivikr opened this issue Jan 5, 2022 · 2 comments
Closed

Move @types/node devDependency to root package.json #3142

trivikr opened this issue Jan 5, 2022 · 2 comments
Labels
closed-for-staleness feature-request New feature or enhancement. May require GitHub community feedback.

Comments

@trivikr
Copy link
Member

trivikr commented Jan 5, 2022

Is your feature request related to a problem? Please describe.

There were multiple CI errors when trying to move @types/node as a devDependency in root package.json in #3139

Describe the solution you'd like

Since AWS SDK for JavaScript (v3) supports Node.js >=12.0.0, fix these errors and use @types/node@12.0.0 as a devDependency in root.

Describe alternatives you've considered

N/A
@trivikr trivikr added the feature-request New feature or enhancement. May require GitHub community feedback. label Jan 5, 2022
@trivikr trivikr mentioned this issue Jan 5, 2022
Merged
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

Greetings! We’re closing this issue because it has been open a long time and hasn’t been updated in a while and may not be getting the attention it deserves. We encourage you to check if this is still an issue in the latest release and if you find that this is still a problem, please feel free to comment or open a new issue.

@github-actions github-actions bot added closing-soon This issue will automatically close in 4 days unless further comments are made. closed-for-staleness and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Jan 6, 2023
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed-for-staleness feature-request New feature or enhancement. May require GitHub community feedback.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trivikr