Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): add client config interface test with s3 example #4156

Merged
merged 4 commits into from
Nov 10, 2022

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Nov 9, 2022

Issue

#4122

Our client config types are a mash of many different types due to being piped through many config resolvers.
The endpoints 2.0 changes modified the runtime type of the config and broke the type contract for resolvedEndpointConfig, which had assumed endpoint would be set.

This test package aims to stabilize the client config resolved interface.

Description

  • this adds a private package that is only used for unit testing
  • the tests check that a minimal and maximal configuration for a client (S3 used as example) resolve the expected fields

Testing

  • added unit tests
  • added build test for client api (S3 used as example)

@kuhe kuhe merged commit 7811cd9 into aws:main Nov 10, 2022
@kuhe kuhe deleted the fix/endpoint-typing branch November 10, 2022 16:59
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants