Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): internal serde function name shortening #4611

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

kuhe
Copy link
Contributor

@kuhe kuhe commented Apr 4, 2023

Issue

see smithy-lang/smithy-typescript#730

Description

shorten serde function names

Testing

yarn generate-clients and full build. Because this is a function rename, compilation is a strong indicator.

  • protocol tests passing
  • JSv3 integration tests - make turbo-build (=build:all), then npx cucumber-js.
npx cucumber-js
............................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................

147 scenarios (147 passed)
488 steps (488 passed)
1m56.742s (executing steps: 1m54.962s)

@kuhe kuhe force-pushed the feat/function-names branch 3 times, most recently from 4064f2f to f2e8a11 Compare April 5, 2023 21:45
@kuhe kuhe marked this pull request as ready for review April 5, 2023 21:45
@kuhe kuhe requested a review from a team as a code owner April 5, 2023 21:45
@kuhe
Copy link
Contributor Author

kuhe commented Apr 5, 2023

EC2 comparison

prior:

npm notice === Tarball Details ===
npm notice name:          @aws-sdk/client-ec2
npm notice version:       3.306.0
npm notice filename:      @aws-sdk/client-ec2-3.306.0.tgz
npm notice package size:  1.2 MB
npm notice unpacked size: 15.6 MB
npm notice shasum:        bfbb8f55247583dba3eec140848d2831ed746021
npm notice integrity:     sha512-aZpPX6Np/JfV6[...]QHZLAkDoDM06A==
npm notice total files:   2358

wc dist-cjs/protocols/Aws_ec2.js
  66,550  214,719 2,817,729 dist-cjs/protocols/Aws_ec2.js

post:

npm notice === Tarball Details ===
npm notice name:          @aws-sdk/client-ec2
npm notice version:       3.306.0
npm notice filename:      @aws-sdk/client-ec2-3.306.0.tgz
npm notice package size:  1.2 MB
npm notice unpacked size: 15.3 MB
npm notice shasum:        e2059b5dbd5b2dd70cf344db797d2a16dd27c351
npm notice integrity:     sha512-7KujAbRcYDYOa[...]a6fQTwX8D3tcQ==
npm notice total files:   2358

wc dist-cjs/protocols/Aws_ec2.js
  66,547  214,719 2,649,161 dist-cjs/protocols/Aws_ec2.js

@kuhe kuhe force-pushed the feat/function-names branch 4 times, most recently from 3cb9902 to 719d097 Compare April 6, 2023 20:12
@kuhe kuhe merged commit e385e85 into aws:main Apr 6, 2023
@kuhe kuhe deleted the feat/function-names branch April 6, 2023 21:24
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants