From 88aa3cfb79612ca8f888f501e2b1bad369a4fd81 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Thu, 18 Apr 2024 20:04:01 +0000 Subject: [PATCH 1/2] chore(codegen): enable string list header bindings that require quoting --- .../smithy/aws/typescript/codegen/AwsProtocolUtils.java | 6 ------ 1 file changed, 6 deletions(-) diff --git a/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsProtocolUtils.java b/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsProtocolUtils.java index 0e58c5d94e01..3c94249dcca6 100644 --- a/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsProtocolUtils.java +++ b/codegen/smithy-aws-typescript-codegen/src/main/java/software/amazon/smithy/aws/typescript/codegen/AwsProtocolUtils.java @@ -316,12 +316,6 @@ private static boolean filterProtocolTests( return true; } - // TODO: remove when there's a decision on separator to use - // https://github.com/awslabs/smithy/issues/1014 - if (testCase.getId().equals("RestJsonInputAndOutputWithQuotedStringHeaders")) { - return true; - } - // TODO: implementation change pending. List extraUnionKey = Arrays.asList( "RestXmlHttpPayloadWithUnsetUnion", From 4f34ef1966f641c05a6701ce10832ad51a26dd60 Mon Sep 17 00:00:00 2001 From: "Kamat, Trivikram" <16024985+trivikr@users.noreply.github.com> Date: Thu, 18 Apr 2024 20:05:54 +0000 Subject: [PATCH 2/2] test(protocoltests): string list header bindings that require quoting --- .../test/functional/restjson1.spec.ts | 4 ++-- private/aws-restjson-server/test/functional/restjson1.spec.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/private/aws-protocoltests-restjson/test/functional/restjson1.spec.ts b/private/aws-protocoltests-restjson/test/functional/restjson1.spec.ts index 4695682c295b..58ab35c7b93d 100644 --- a/private/aws-protocoltests-restjson/test/functional/restjson1.spec.ts +++ b/private/aws-protocoltests-restjson/test/functional/restjson1.spec.ts @@ -3497,7 +3497,7 @@ it("RestJsonInputAndOutputWithStringHeaders:Request", async () => { /** * Tests requests with string list header bindings that require quoting */ -it.skip("RestJsonInputAndOutputWithQuotedStringHeaders:Request", async () => { +it("RestJsonInputAndOutputWithQuotedStringHeaders:Request", async () => { const client = new RestJsonProtocolClient({ ...clientParams, requestHandler: new RequestSerializationTestHandler(), @@ -3888,7 +3888,7 @@ it("RestJsonInputAndOutputWithStringHeaders:Response", async () => { /** * Tests responses with string list header bindings that require quoting */ -it.skip("RestJsonInputAndOutputWithQuotedStringHeaders:Response", async () => { +it("RestJsonInputAndOutputWithQuotedStringHeaders:Response", async () => { const client = new RestJsonProtocolClient({ ...clientParams, requestHandler: new ResponseDeserializationTestHandler(true, 200, { diff --git a/private/aws-restjson-server/test/functional/restjson1.spec.ts b/private/aws-restjson-server/test/functional/restjson1.spec.ts index 0e49a469eefa..e2fdc5b54f0f 100644 --- a/private/aws-restjson-server/test/functional/restjson1.spec.ts +++ b/private/aws-restjson-server/test/functional/restjson1.spec.ts @@ -4046,7 +4046,7 @@ it("RestJsonInputAndOutputWithStringHeaders:ServerRequest", async () => { /** * Tests requests with string list header bindings that require quoting */ -it.skip("RestJsonInputAndOutputWithQuotedStringHeaders:ServerRequest", async () => { +it("RestJsonInputAndOutputWithQuotedStringHeaders:ServerRequest", async () => { const testFunction = jest.fn(); testFunction.mockReturnValue(Promise.resolve({})); const testService: Partial> = { @@ -4551,7 +4551,7 @@ it("RestJsonInputAndOutputWithStringHeaders:ServerResponse", async () => { /** * Tests responses with string list header bindings that require quoting */ -it.skip("RestJsonInputAndOutputWithQuotedStringHeaders:ServerResponse", async () => { +it("RestJsonInputAndOutputWithQuotedStringHeaders:ServerResponse", async () => { class TestService implements Partial> { InputAndOutputWithHeaders(input: any, ctx: {}): Promise { const response = {