Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0.43 reverted some of the waiters like networkinterfaceavailable #818

Closed
eniskonuk opened this issue May 17, 2015 · 3 comments
Closed

Comments

@eniskonuk
Copy link
Contributor

Is there a reason why the waiters that I had put into the code via a pull request got reverted back? Our code just stopped working when we updated to 2.0.43. Can these be merged back in?
Thx
Enis

@trevorrowe
Copy link
Member

I'll take a look at getting this fixed. My guess is merged changes did not get merged upstream. When @awood45 pulled the updated API files for Thursday's release, is probably when these got reverted. My apologies.

@trevorrowe
Copy link
Member

It looks like it was merged and shipped with v2.0.39 and then lost in v2.0.40. The offending commit is here: f0fad0a. I've gone back and merged this upstream. The fix will be shipped today. I also audited all of the other changes made in your pull-request. The other changes have been merged up-stream and are intact.

Sorry for the confusion and inconvenience. We are currently looking at the process on how we update and maintain some of these shared metadata files. As the Ruby SDK is not the source, we need a better process to ensure we don't have regressions like this in the future.

@eniskonuk
Copy link
Contributor Author

@trevorrowe 💯 Thanks

@srchase srchase added the bug label Dec 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants