Don't Read IO Objects in Attribute Value Marshal #832
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Issue #831
Running the following code exercised the problem, and now works with
this change:
The issue appeared to be that #read was called twice on the StringIO or
IO object, and the second call would fail as String#read does not
exist.
One thing I'd like to review further before merging is the fact that maps and collections do this same #read call but do not have this problem when tested.