-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change osImageURL to be a required field in docs #8414
Change osImageURL to be a required field in docs #8414
Conversation
Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8414 +/- ##
=======================================
Coverage 73.48% 73.48%
=======================================
Files 578 578
Lines 36489 36489
=======================================
Hits 26814 26814
Misses 7956 7956
Partials 1719 1719 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.20 |
@rahulbabu95: new pull request created: #8415 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
In release 0.19 we changed the osImageURL field in our API to be a required field from optional. And in release-0.20 we changed the osImageURL field on TinkerbellMachineConfigs also to be a required field. Call these changes out on the docs.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.