Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change osImageURL to be a required field in docs #8414

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

rahulbabu95
Copy link
Member

Description of changes:
In release 0.19 we changed the osImageURL field in our API to be a required field from optional. And in release-0.20 we changed the osImageURL field on TinkerbellMachineConfigs also to be a required field. Call these changes out on the docs.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Rahul Ganesh added 2 commits June 28, 2024 12:27
Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 28, 2024
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.48%. Comparing base (ebcd518) to head (9bbb644).

Current head 9bbb644 differs from pull request most recent head 125baad

Please upload reports for the commit 125baad to get more accurate results.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8414   +/-   ##
=======================================
  Coverage   73.48%   73.48%           
=======================================
  Files         578      578           
  Lines       36489    36489           
=======================================
  Hits        26814    26814           
  Misses       7956     7956           
  Partials     1719     1719           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rahul Ganesh <rahulgab@amazon.com>
@rahulbabu95
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahulbabu95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 6ed1a95 into aws:main Jun 28, 2024
6 checks passed
@rahulbabu95
Copy link
Member Author

/cherrypick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@rahulbabu95: new pull request created: #8415

In response to this:

/cherrypick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants