Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-termination-handler servicemonitor has the wrong labels #722

Closed
James-Quigley opened this issue Apr 5, 2022 · 2 comments · Fixed by #1155
Closed

node-termination-handler servicemonitor has the wrong labels #722

James-Quigley opened this issue Apr 5, 2022 · 2 comments · Fixed by #1155
Assignees
Labels
bug Something isn't working

Comments

@James-Quigley
Copy link

Describe the bug
The selectors on the servicemonitor do not match the labels on the service. Namely app.kubernetes.io/component: deployment. Therefore metrics cannot be scraped because there is no matching target

Steps to reproduce

Deploy the helm chart in queue mode, and enable the servicemonitor

Expected outcome
The selectors on the servicemonitor should match what exists on the service

Environment

  • Chart name:
    aws-node-termination-handler
  • Chart version:
    0.18.0
  • Kubernetes version:
    1.21
  • Using EKS (yes/no), if so version?
    Yes. 1.21

Additional Context:

@James-Quigley James-Quigley added the bug Something isn't working label Apr 5, 2022
@jaypipes
Copy link
Contributor

jaypipes commented Apr 6, 2022

@bwagner5 any chance you can take a look into this one?

@bwagner5
Copy link
Collaborator

bwagner5 commented Apr 6, 2022

@James-Quigley this was recently fixed and will be released in eks-charts soon: aws/aws-node-termination-handler#604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants