fix(diff): check base types #1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that an updated type still extends all of its previous base types, so that objects of the updated type can still be assigned to variables or passed into parameters of the declared supertype. This check would have prevented a deployment failure during a big refactoring of the CDK.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
eladb
approved these changes
Mar 19, 2020
| * still a supertype of T'. | ||
| */ | ||
| function assignableToAllBaseTypes(original: reflect.ReferenceType, updated: reflect.ReferenceType): Analysis { | ||
| for (const B of baseTypes(original)) { |
There was a problem hiding this comment.
Suggested change
| for (const B of baseTypes(original)) { | |
| for (const base of baseTypes(original)) { |
There was a problem hiding this comment.
Yeah. Well it was B on purpose to match the docstring just above it.
But sure.
RomainMuller
approved these changes
Mar 23, 2020
|
Cool. Now we just have to wait for @MrArnoldPalmer |
MrArnoldPalmer
approved these changes
Mar 23, 2020
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that an updated type still extends all of its previous base types,
so that objects of the updated type can still be assigned to variables
or passed into parameters of the declared supertype.
This check would have prevented a deployment failure during a big
refactoring of the CDK.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.