fix: improve compatibility with restricted-export modules #3205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modules can decide they don't export `package.json`, and our methods
of using `require.resolve('the-package/package.json')` to find the
package will fail.
Instead, resolve the main entry point and search upward for
`package.json`, bypassing `require()`.
rix0rrr
changed the title
… into huijbers/no-reflect-require
RomainMuller
reviewed
Dec 6, 2021
| /** | ||
| * Find the directory that contains a given dependency, identified by its 'package.json', from a starting search directory | ||
| */ | ||
| export async function findDependencyDirectory( |
There was a problem hiding this comment.
Is this implementation a copy of the one in jsii-pacmak? I wouldn't mind a @jsii/utils package...
There was a problem hiding this comment.
Yeeeeaaa -- hhh... I don't disagree, but I didn't want to make too many changes at once
Co-authored-by: Romain Marcadier <rmuller@amazon.lu>
RomainMuller
approved these changes
Dec 6, 2021
… into huijbers/no-reflect-require
rix0rrr
added a commit
that referenced
this pull request
Dec 9, 2021
Fixes for some cases that were introduced in #3205, that cropped up during a full CDK build: - Some `@types/xxx` modules use an `exports` field, changing the error we get when trying (and failing) to import it. - `punycode` is both an NPM dependency and a built-in. The built-in takes precedence and changes the return value of `require.resolve()` to something unexpected.
rix0rrr
added a commit
that referenced
this pull request
Dec 9, 2021
Fixes for some cases that were introduced in #3205, that cropped up during a full CDK build: - Some `@types/xxx` modules use an `exports` field, changing the error we get when trying (and failing) to import it. - `punycode` is both an NPM dependency and a built-in. The built-in takes precedence and changes the return value of `require.resolve()` to something unexpected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modules can decide they don't export
package.json, and our methodsof using
require.resolve('the-package/package.json')to find thepackage will fail.
Instead, resolve the main entry point and search upward for
package.json, bypassingrequire().We have been doing all of:
require('the-package/package.json')require.resolve('the-package/.jsii')require.resolve('the-package/tsconfig.json')Replace all these with a
require.resolve('the-package')thenfindUpRelates to aws/aws-cdk#17707
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.