fix(python): cannot import nested submodules #3540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nested submodules were not registered in the `__all__` list of their parent, and so were not visible to import statement such as `from fully.qualified.submodule.path import Name`. This changes how submodules get loaded so that they are always declared and loaded with the context of their immediate parent sub•module, which guarantees they are present in the relevant `__all__` list. Fixes #3408
RomainMuller
force-pushed
the
rmuller/py-submodules
branch
from
b80b875
to
39fae40
Compare
rix0rrr
approved these changes
May 13, 2022
agdimech
approved these changes
May 13, 2022
agdimech
approved these changes
May 13, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nested submodules were not registered in the
__all__list of theirparent, and so were not visible to import statement such as
from fully.qualified.submodule.path import Name.This changes how submodules get loaded so that they are always declared
and loaded with the context of their immediate parent sub•module, which
guarantees they are present in the relevant
__all__list.Fixes #3408
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.