feat(go): runtime type check type unions #3712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Runtime type-checking can be disabled by adding `--tag=no_runtime_type_checks` to go compiler invocations. This can be used to avoid paying the performance toll of runtime type checking (which should be modest in most cases), or to work around a bug in the type checking code.
RomainMuller
force-pushed
the
rmuller/go-type-checking
branch
from
f3d033f
to
441fe5b
Compare
comcalvi
requested changes
Aug 23, 2022
packages/@jsii/go-runtime/jsii-runtime-go/internal/typeregistry/registration.go
Show resolved
Hide resolved
comcalvi
reviewed
Aug 23, 2022
comcalvi
requested changes
Aug 23, 2022
packages/@jsii/go-runtime-test/project/runtime_type_checking_test.go
Outdated
Show resolved
Hide resolved
comcalvi
reviewed
Aug 23, 2022
# Conflicts: # packages/jsii-pacmak/test/generated-code/__snapshots__/target-dotnet.test.js.snap # packages/jsii-pacmak/test/generated-code/__snapshots__/target-go.test.js.snap # packages/jsii-pacmak/test/generated-code/__snapshots__/target-python.test.js.snap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runtime type-checking can be disabled by adding
--tag=no_runtime_type_checkingto go compiler invocations. This canbe used to avoid paying the performance toll of runtime type checking
(which should be modest in most cases), or to work around a bug in the
type checking code.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.