fix(pacmak): .NET bindings fail to compile with error CS8120 #3760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a type union includes several candidates that are related to each other (A extends B or A implements B), `jsii-pacmak` may generate type checking clauses in a pattern matching `switch` statement in an order such that the compiler identifies dead clauses, which is an error in C#. This adds a provision to NOT emit such a clause so as to not cause the error. It is worth mentioning that the error cannot be "opted out" of via a `#pragma` directive like a warning would be, which is unfortunate. Fixes #3759
DanielMSchmidt
approved these changes
Sep 21, 2022
| @@ -21,5 +21,6 @@ | |||
| "composite": true, /* Ensure TypeScript can determine where to find the outputs of the referenced project to compile project. */ | |||
| "incremental": true, /* Enable incremental compilation by reading/writing information from prior compilations to a file on disk. */ | |||
| "useDefineForClassFields": false, /* Use Object.defineProperty for introducing class fields. */ | |||
| "skipLibCheck": true, /* Skip type checking of declaration files. */ | |||
There was a problem hiding this comment.
This seems unrelated, was this an error?
There was a problem hiding this comment.
Yeah this is unrelated but does not hurt :) It's a recommended setting in TypeScript and could make builds somewhat faster.
| @@ -172,6 +172,26 @@ abstract class Validation { | |||
| code.openBlock(`switch (${expression})`); | |||
| for (const type of types) { | |||
| validTypes.push(resolver.toDotNetTypeName(type.spec!)); | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Great explanation 👍
iliapolo
approved these changes
Sep 21, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
1 similar comment
|
Merging (with squash)... |
|
Merging (with squash)... |
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a type union includes several candidates that are related to each other (A extends B or A implements B),
jsii-pacmakmay generate type checking clauses in a pattern matchingswitchstatement in an order such that the compiler identifies dead clauses, which is an error in C#.This adds a provision to NOT emit such a clause so as to not cause the error. It is worth mentioning that the error cannot be "opted out" of via a
#pragmadirective like a warning would be, which is unfortunate.Fixes #3759
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.