feat(python): add error differentiation to Python. #3772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethod can't distinguish them yet
…ach, needs to be fixed before this can be merged
…ents the fault. JSException is now java.lang.RuntimeException.
...sii/java-runtime-test/project/src/test/java/software/amazon/jsii/testing/ComplianceTest.java
Outdated
Show resolved
Hide resolved
...sii/java-runtime-test/project/src/test/java/software/amazon/jsii/testing/JsiiClientTest.java
Outdated
Show resolved
Hide resolved
packages/@jsii/java-runtime/project/src/main/java/software/amazon/jsii/JsiiEngine.java
Outdated
Show resolved
Hide resolved
packages/@jsii/java-runtime/project/src/main/java/software/amazon/jsii/JsiiEngine.java
Outdated
Show resolved
Hide resolved
packages/@jsii/java-runtime/project/src/main/java/software/amazon/jsii/JsiiEngine.java
Outdated
Show resolved
Hide resolved
packages/@jsii/java-runtime/project/src/main/java/software/amazon/jsii/JsiiRuntime.java
Outdated
Show resolved
Hide resolved
RomainMuller
approved these changes
Sep 28, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
1 similar comment
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
RuntimeErrorandJsiiErrorto indicate recoverable vs non-recoverable errors respectively. Also fixes three bugs in the Java logic for the same feature:RuntimeExceptionin the string where it should have usedRuntimeError, meaning that some errors would always be rethrown asRuntimeExceptions even when they should beJsiiErrors.These bugs happened because the Java tests did not check for type of the exception thrown, meaning that
JsiiErrors could be passed whereRuntimeExceptions were expected. The tests now verify the type of the exception thrown.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.