fix(dotnet): broken error name deserialization #3855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where the `name` field of an `ErrorResponse` would not deserialize into our enum of known names correctly. Initially it was thought that if the `name` field was non-null, it would only be one of our known values, but the kernel is in fact not setting this field explicitly in all cases of "user land" errors. This results in the `name` field being `"Error"`in the default case and would cause a JSON deserialization error. Implements a custom deserializer for the `ErrorResponseName` to explicitly return null if the string is not defined or unknown. Additionally makes the `name` field nullable. fix: aws/aws-cdk#22369
|
This took me a min to repro as it only occurs in |
RomainMuller
approved these changes
Nov 24, 2022
RomainMuller
approved these changes
Nov 24, 2022
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the
namefield of anErrorResponsewould not deserialize into our enum of known names correctly. Initially it was thought that if thenamefield was non-null, it would only be one of our known values, but the kernel is in fact not setting this field explicitly in all cases of "user land" errors. This results in thenamefield being"Error"in the default case and would cause a JSON deserialization error.Implements a custom deserializer for the
ErrorNameto explicitly return null if the string is not defined or unknown. Additionally makes thenamefield nullable.fix: aws/aws-cdk#22369
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.