Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pacmak): runtime dependency should match pacmak release #4013

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

RomainMuller
Copy link
Contributor

The code generated by jsii-pacmak has a dependency on jsii runtime versions that are expected to match that of jsii-pacmak itself. This fixes the .NET and Python generators using the assembly's jsiiVersion property, which is a metadata field supposed to only indicate what version of the compiler was used to build the assembly.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

The code generated by `jsii-pacmak` has a dependency on jsii runtime
versions that are expected to match that of `jsii-pacmak` itself.
This fixes the .NET and Python generators using the assembly's
`jsiiVersion` property, which is a metadata field supposed to only
indicate what version of the compiler was used to build the assembly.
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Mar 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 16, 2023

Merging (with squash)...

@mergify mergify bot merged commit 37c29f7 into main Mar 16, 2023
@mergify mergify bot deleted the rmuller/fix-runtime-version branch March 16, 2023 15:37
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants