Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configurable pack command #4021

Merged
merged 5 commits into from
Mar 22, 2023
Merged

Conversation

agdimech
Copy link
Contributor

@agdimech agdimech commented Mar 21, 2023

This PR adds support for configuring a custom pack command. This is needed when using other package managers like pnpm.

In terms of usage, developers would configure pacmak to use pnpm for example as follows:

jsii-pacmak --pack-command='pnpm pack'

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

packages/jsii-pacmak/lib/packaging.ts Outdated Show resolved Hide resolved
packages/jsii-pacmak/lib/packaging.ts Outdated Show resolved Hide resolved
packages/jsii-pacmak/lib/packaging.ts Outdated Show resolved Hide resolved
@agdimech agdimech changed the title feat: add configurable npm pack command feat: add configurable pack command Mar 21, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2023

Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it!

@mergify mergify bot added the pr/ready-to-merge This PR is ready to be merged. label Mar 22, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 22, 2023

Merging (with squash)...

@mergify mergify bot merged commit 6b2fd18 into aws:main Mar 22, 2023
@mergify mergify bot removed the pr/ready-to-merge This PR is ready to be merged. label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants