-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): reject auto upgrade of prettier #2843
Conversation
prettier@2.3.0 is now enforcing Allman brace styles, while the code base uses 1tbs (one true brace style). In fact, the latter has been explicitly configured in eslint. There does not seem to be a way to configure prettier to switch styles.
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
Merging (with squash)... |
Isn't it possible to configure prettier accordingly? |
It looks related to this change which only applies to classes with multiline We likely could make eslint ignore this and just let prettier handle it (thats what eslint-config-prettier is for but maybe it hasn't caught up?). At the top of that same release notes page it recommends not using a ^ version of prettier though so this seems good anyway. |
@eladb - I could not find such an option. I believe this is because of prettier's philosophy
@MrArnoldPalmer - Here's how that would look - #2835. Is that a better change? |
@nija-at yeah lets take that. I think just letting Prettier handle everything it does and using Eslint only for non-formatting related stuff is our preferred experience. TY for that! |
prettier@2.3.0 is now enforcing Allman brace styles, while the code
base uses 1tbs (one true brace style).
In fact, the latter has been explicitly configured in eslint.
There does not seem to be a way to configure prettier to switch styles.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.