Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix status not updating when the spec has an update #136

Merged

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

  • Fixes a bug where any typed controller implementation wouldn't update its Status() if the spec or metadata had an update

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner December 20, 2022 03:36
@jonathan-innis jonathan-innis force-pushed the fix-generic-controller branch 2 times, most recently from 6fdb78b to 770540d Compare December 20, 2022 03:39
@coveralls
Copy link

coveralls commented Dec 20, 2022

Pull Request Test Coverage Report for Build 3742374208

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • 11 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.02%) to 77.556%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/operator/controller/typed.go 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
pkg/operator/controller/typed.go 4 88.24%
pkg/controllers/node/controller.go 7 66.67%
Totals Coverage Status
Change from base Build 3736800606: -0.02%
Covered Lines: 5719
Relevant Lines: 7374

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 15a2378 into kubernetes-sigs:main Dec 20, 2022
@jonathan-innis jonathan-innis deleted the fix-generic-controller branch December 20, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants