chore: Create state.Node interface methods to access cluster state details
#152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
force-pushed
the
merged-cluster-state
branch
2 times, most recently
from
1170f22
to
5251ce7
Compare
jonathan-innis
force-pushed
the
merged-cluster-state
branch
3 times, most recently
from
8c567a2
to
ef4bca4
Compare
jonathan-innis
force-pushed
the
merged-cluster-state
branch
5 times, most recently
from
911a232
to
cfff5af
Compare
|
Before PR === RUN TestSchedulingProfile
scheduled 7610 against 21 nodes in total in 3.927209844s 1937.7625088271193 pods/sec
400 instances 10 pods 1 nodes 3.157028ms per scheduling 315.702µs per pod
400 instances 100 pods 1 nodes 32.386241ms per scheduling 323.862µs per pod
400 instances 500 pods 1 nodes 148.849796ms per scheduling 297.699µs per pod
400 instances 1000 pods 3 nodes 338.482729ms per scheduling 338.482µs per pod
400 instances 1500 pods 4 nodes 536.756792ms per scheduling 357.837µs per pod
400 instances 2000 pods 5 nodes 648.753041ms per scheduling 324.376µs per pod
400 instances 2500 pods 6 nodes 736.882146ms per scheduling 294.752µs per pod
--- PASS: TestSchedulingProfile (13.59s)
PASSAfter PR === RUN TestSchedulingProfile
scheduled 7610 against 20 nodes in total in 4.016303065s 1894.7773305050625 pods/sec
400 instances 10 pods 1 nodes 3.097744ms per scheduling 309.774µs per pod
400 instances 100 pods 1 nodes 32.313276ms per scheduling 323.132µs per pod
400 instances 500 pods 1 nodes 153.221583ms per scheduling 306.443µs per pod
400 instances 1000 pods 3 nodes 339.300361ms per scheduling 339.3µs per pod
400 instances 1500 pods 4 nodes 541.017812ms per scheduling 360.678µs per pod
400 instances 2000 pods 4 nodes 588.58475ms per scheduling 294.292µs per pod
400 instances 2500 pods 6 nodes 792.721666ms per scheduling 317.088µs per pod
--- PASS: TestSchedulingProfile (14.09s)
PASSEffectively the same benchmarking between before/after PR |
ellistarn
reviewed
Jan 5, 2023
jonathan-innis
force-pushed
the
merged-cluster-state
branch
2 times, most recently
from
72716d8
to
c0b9477
Compare
jonathan-innis
force-pushed
the
merged-cluster-state
branch
from
c0b9477
to
d67c432
Compare
tzneal
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
state.Nodeinterface methods to access cluster state detailsProvisionerfromExistingNodeso thatExistingNodescan be built purely based onstate.NodeHow was this change tested?
make presubmitFOCUS=Scheduling make e2etestsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.