Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove auto-patching from typed controllers #159

Merged

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Jan 9, 2023

Fixes aws/karpenter-provider-aws#3153
Fixes #153

Description

  • Remove auto-patching from typed controllers
  • This doesn't add patch helpers for not patching on no change yet since it felt like an unnecessary abstraction given the amount of patching that we are currently doing.

How was this change tested?

make presubmit
FOCUS=Scheduling make e2etests
FOCUS=Emptiness make e2etests
FOCUS=Termination make e2etests

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis force-pushed the remove-autopatch branch 3 times, most recently from 57f224b to 9ec3921 Compare January 9, 2023 06:14
@jonathan-innis jonathan-innis marked this pull request as ready for review January 9, 2023 06:23
@jonathan-innis jonathan-innis requested a review from a team as a code owner January 9, 2023 06:23
@coveralls
Copy link

coveralls commented Jan 9, 2023

Pull Request Test Coverage Report for Build 3871294991

  • 16 of 27 (59.26%) changed or added relevant lines in 6 files are covered.
  • 20 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.1%) to 76.277%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/node/controller.go 7 9 77.78%
pkg/controllers/termination/controller.go 3 6 50.0%
pkg/controllers/counter/controller.go 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/counter/controller.go 1 0%
pkg/controllers/deprovisioning/controller.go 3 70.33%
pkg/controllers/node/controller.go 7 72.73%
pkg/controllers/deprovisioning/events/events.go 9 80.0%
Totals Coverage Status
Change from base Build 3857342106: -0.1%
Covered Lines: 5749
Relevant Lines: 7537

💛 - Coveralls

@jonathan-innis jonathan-innis merged commit 1682744 into kubernetes-sigs:main Jan 10, 2023
@jonathan-innis jonathan-innis deleted the remove-autopatch branch January 10, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants