Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Make settings.settings copyable #177

Merged
merged 1 commit into from
Jan 26, 2023
Merged

chore: Make settings.settings copyable #177

merged 1 commit into from
Jan 26, 2023

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

  • Make settings copyable
  • This change is needed so that we can deep-copy the default settings when we inject them into the context

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner January 26, 2023 19:25
@jonathan-innis jonathan-innis changed the title chore: Make settings copyable chore: Make settings.settings copyable Jan 26, 2023
@coveralls
Copy link

coveralls commented Jan 26, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4018470809

  • 15 of 17 (88.24%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 79.284%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/settings/zz_generated.deepcopy.go 10 12 83.33%
Totals Coverage Status
Change from base Build 4018247924: -0.006%
Covered Lines: 6399
Relevant Lines: 8071
💛 - Coveralls

@jonathan-innis jonathan-innis enabled auto-merge (squash) January 26, 2023 19:54
bwagner5
bwagner5 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonathan-innis jonathan-innis merged commit 08b676a into kubernetes-sigs:main Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwagner5 bwagner5 bwagner5 approved these changes

@engedaam engedaam Awaiting requested review from engedaam engedaam was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonathan-innis @coveralls @bwagner5