Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add a ttlAfterNotRegistered value to global settings for v1alpha5.Machine #191

Merged
merged 2 commits into from
Feb 3, 2023
Merged

chore: Add a ttlAfterNotRegistered value to global settings for v1alpha5.Machine #191

merged 2 commits into from
Feb 3, 2023

Conversation

jonathan-innis
Copy link
Member

Fixes #

Description

  • Add a ttlAfterNotRegistered value to global settings for v1alpha5.Machine

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jonathan-innis jonathan-innis requested a review from a team as a code owner January 31, 2023 23:27
@jonathan-innis jonathan-innis force-pushed the ttl-after-not-registered branch 2 times, most recently from 2203b64 to 99d045f Compare January 31, 2023 23:34
@coveralls
Copy link

coveralls commented Jan 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4088495755

  • 60 of 61 (98.36%) changed or added relevant lines in 6 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 78.511%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/apis/settings/settings.go 17 18 94.44%
Files with Coverage Reduction New Missed Lines %
pkg/test/cachesyncingclient.go 2 73.91%
Totals Coverage Status
Change from base Build 4087324935: 0.1%
Covered Lines: 6262
Relevant Lines: 7976
💛 - Coveralls

@jonathan-innis jonathan-innis force-pushed the ttl-after-not-registered branch 5 times, most recently from 1b5275f to 22f4b56 Compare February 1, 2023 00:28
@jonathan-innis jonathan-innis force-pushed the ttl-after-not-registered branch 4 times, most recently from 89f03ca to 044712e Compare February 1, 2023 17:50
njtran
njtran reviewed Feb 3, 2023
View reviewed changes
pkg/apis/settings/settings.go Show resolved Hide resolved
pkg/apis/settings/settings.go Outdated Show resolved Hide resolved
pkg/controllers/machine/registration.go Outdated Show resolved Hide resolved
pkg/controllers/machine/suite_test.go Show resolved Hide resolved
@jonathan-innis jonathan-innis force-pushed the ttl-after-not-registered branch 6 times, most recently from eea038d to cd85559 Compare February 3, 2023 20:28
@jonathan-innis jonathan-innis enabled auto-merge (squash) February 3, 2023 22:30
njtran
njtran reviewed Feb 3, 2023
View reviewed changes
pkg/apis/crds/karpenter.sh_machines.yaml Outdated Show resolved Hide resolved
pkg/apis/settings/settings.go Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
njtran
njtran approved these changes Feb 3, 2023
View reviewed changes
Copy link
Contributor

@njtran njtran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@jonathan-innis jonathan-innis merged commit 1799d43 into kubernetes-sigs:main Feb 3, 2023
@jonathan-innis jonathan-innis mentioned this pull request Feb 6, 2023
Closed
3 tasks
@ajaykumarmandapati
Copy link

ajaykumarmandapati commented Feb 7, 2023 •
edited
Loading

@jonathan-innis Nice work! 🏆 Do you already know in which version of karpenter would this param be available?

@jonathan-innis
Copy link
Member Author

@ajaykumarmandapati This is coming with some other work down the pipe surrounding node ownership, which is why this was marked as a chore and not a feat. When that work is completed, this feature will also come with it.

@ajaykumarmandapati
Copy link

ajaykumarmandapati commented Feb 22, 2023 •
edited
Loading

Hey @jonathan-innis thanks for your answer, if I understand correctly karpenter-core v0.24 is where this was introduced and does that mean this is configurable in karpenter version v0.24 ?
Thanks for your answer!

@jonathan-innis
Copy link
Member Author

@ajaykumarmandapati This is included in the code in v0.24.0, but not used anywhere in the codebase. When #176 gets fully released, that's when this will be available for use inside of the karpenter-global-settings and when we will start to document it

@billrayburn billrayburn mentioned this pull request Feb 23, 2023
Open
@korenyoni
Copy link

korenyoni commented Mar 5, 2023 •
edited
Loading

By the way, the following inline comment should be updated (probably part of #176?). Right now it suggests ttlAfterNotRegistered is not here to stay, even though the discussions above suggest that it's a permanent feature https://github.com/aws/karpenter-core/blob/c4e086296760ac3b9c33525032ec3e2f09f31fee/charts/karpenter-core/values.yaml#L141-L146

@jonathan-innis
Copy link
Member Author

@korenyoni This feature is here to stay in the short-term, but we're not confident this will change in the long-term. This feature was packaged in this PR, to reduce the scope of #176 since that PR has continued to grow in size.

@jonathan-innis jonathan-innis mentioned this pull request Mar 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njtran njtran njtran approved these changes

@bwagner5 bwagner5 Awaiting requested review from bwagner5 bwagner5 was automatically assigned from aws/karpenter

@ellistarn ellistarn Awaiting requested review from ellistarn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jonathan-innis @coveralls @ajaykumarmandapati @korenyoni @ellistarn @njtran