test: Deflake deprovisioning testing #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4098985287
💛 - Coveralls |
jonathan-innis
force-pushed
the
deflake-deprovisioning-tests
branch
from
e752526
to
95379eb
Compare
jonathan-innis
force-pushed
the
deflake-deprovisioning-tests
branch
from
95379eb
to
039b31a
Compare
ellistarn
reviewed
Feb 6, 2023
ellistarn
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
go triggerVerifyAction()was sometimes running after the test had completed. This meant that subsequent tests would trigger the verify action before they were expected, polluting the testsync.WaitGroupso that we wait for thetriggerVerifyActionto complete before proceeding to the next testHow was this change tested?
make presubmitBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.