Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove deprovisioning.Reporter in favor of native eventing #204

Conversation

jonathan-innis
Copy link
Member

@jonathan-innis jonathan-innis commented Feb 6, 2023

Fixes #

Description

  • Remove deprovisioning.Reporter in favor of native eventing

How was this change tested?

make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coveralls
Copy link

coveralls commented Feb 6, 2023

Pull Request Test Coverage Report for Build 4107113761

  • 26 of 29 (89.66%) changed or added relevant lines in 7 files are covered.
  • 18 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.2%) to 78.312%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/deprovisioning/consolidation.go 7 10 70.0%
Files with Coverage Reduction New Missed Lines %
pkg/controllers/deprovisioning/controller.go 3 76.25%
pkg/utils/pretty/changemonitor.go 6 70.0%
pkg/controllers/deprovisioning/events/events.go 9 80.43%
Totals Coverage Status
Change from base Build 4088627774: -0.2%
Covered Lines: 6236
Relevant Lines: 7963

💛 - Coveralls

@jonathan-innis jonathan-innis changed the title chore: Remove deprovisioning reporter in favor of native eventing chore: Remove deprovisioning.Reporter in favor of native eventing Feb 6, 2023
@jonathan-innis jonathan-innis merged commit a6491a7 into kubernetes-sigs:main Feb 6, 2023
@jonathan-innis jonathan-innis deleted the remove-deprovisoining-reporter branch February 6, 2023 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants