Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only reset consolidation time if an attempt was made #232

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

tzneal
Copy link
Contributor

@tzneal tzneal commented Mar 6, 2023

Fixes #

Description

Don't reset the consolidation time if it didn't actually run.

How was this change tested?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@tzneal tzneal requested a review from a team as a code owner March 6, 2023 15:56
@tzneal tzneal requested a review from bwagner5 March 6, 2023 15:56
@tzneal tzneal force-pushed the fix-consolidation-trigger branch from a50f37c to 4bfa489 Compare March 6, 2023 16:00
bwagner5
bwagner5 previously approved these changes Mar 6, 2023
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

coveralls commented Mar 6, 2023

Pull Request Test Coverage Report for Build 4345458164

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 80.894%

Totals Coverage Status
Change from base Build 4317638787: 0.06%
Covered Lines: 6385
Relevant Lines: 7893

💛 - Coveralls

Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzneal tzneal merged commit 7d58c3c into kubernetes-sigs:main Mar 6, 2023
@tzneal tzneal deleted the fix-consolidation-trigger branch March 6, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants