chore: Remove unneeded webhooks for machines/provisioners #234
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4371972886
💛 - Coveralls |
|
What behavior are we driving with machine webhooks? |
jonathan-innis
force-pushed
the
add-webhooks-for-machines
branch
3 times, most recently
from
de26bd2
to
c1feb40
Compare
jonathan-innis
changed the title
It's a good point. I was adding it for consistency but opting to just rip out the webhooks that we don't need right now |
jonathan-innis
force-pushed
the
add-webhooks-for-machines
branch
2 times, most recently
from
3a592b3
to
9ab1f55
Compare
jonathan-innis
force-pushed
the
add-webhooks-for-machines
branch
from
9ab1f55
to
666037a
Compare
bwagner5
reviewed
Mar 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Description
How was this change tested?
make presubmithelm diff upgrade --namespace karpenter karpenter charts/karpenter --reuse-values --three-way-mergeBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.