Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: problem where pods blocking eviction were not respected for cons… #247

Merged
merged 8 commits into from
Mar 22, 2023
Merged

fix: problem where pods blocking eviction were not respected for cons… #247

merged 8 commits into from
Mar 22, 2023

Conversation

njtran
Copy link
Contributor

@njtran njtran commented Mar 21, 2023 •
edited
Loading

…olidation

Fixes aws/karpenter-provider-aws#3594

Description
Adds an additional check in Consolidation validation to make sure that no new pods that block eviction were scheduled during the 15 Seconds Consolidation TTL.

Also pulls out the common filter code.

How was this change tested?

  • Added unit tests and make presubmit

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@njtran njtran requested a review from a team as a code owner March 21, 2023 23:05
@njtran njtran requested a review from tzneal March 21, 2023 23:05
@coveralls
Copy link

coveralls commented Mar 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4492996563

  • 34 of 48 (70.83%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 81.47%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controllers/deprovisioning/consolidation.go 4 5 80.0%
pkg/controllers/deprovisioning/drift.go 2 3 66.67%
pkg/controllers/deprovisioning/expiration.go 6 9 66.67%
pkg/controllers/deprovisioning/validation.go 5 9 55.56%
pkg/controllers/deprovisioning/helpers.go 15 20 75.0%
Totals Coverage Status
Change from base Build 4473343220: 0.9%
Covered Lines: 6586
Relevant Lines: 8084
💛 - Coveralls

bwagner5
bwagner5 previously approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@bwagner5 bwagner5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@njtran njtran merged commit cb03ff7 into kubernetes-sigs:main Mar 22, 2023
@njtran njtran deleted the consolidationWaitFix branch April 13, 2023 22:20
@jonathan-innis jonathan-innis mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ellistarn ellistarn ellistarn approved these changes

@bwagner5 bwagner5 bwagner5 left review comments

@tzneal tzneal Awaiting requested review from tzneal tzneal was automatically assigned from aws/karpenter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@njtran @coveralls @ellistarn @bwagner5