-
Notifications
You must be signed in to change notification settings - Fork 707
/
s2n_cipher_suite_match_test.c
1420 lines (1228 loc) · 77.7 KB
/
s2n_cipher_suite_match_test.c
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
* Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
*
* Licensed under the Apache License, Version 2.0 (the "License").
* You may not use this file except in compliance with the License.
* A copy of the License is located at
*
* http://aws.amazon.com/apache2.0
*
* or in the "license" file accompanying this file. This file is distributed
* on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
* express or implied. See the License for the specific language governing
* permissions and limitations under the License.
*/
#include <string.h>
#include "crypto/s2n_ecc_evp.h"
#include "crypto/s2n_pq.h"
#include "s2n_test.h"
#include "testlib/s2n_testlib.h"
#include "tls/s2n_cipher_suites.h"
#include "tls/s2n_connection.h"
#include "tls/s2n_security_policies.h"
static s2n_result s2n_conn_set_chosen_psk(struct s2n_connection *conn)
{
RESULT_ENSURE_REF(conn);
uint8_t psk_identity[] = "psk identity";
RESULT_GUARD(s2n_array_pushback(&conn->psk_params.psk_list, (void **) &conn->psk_params.chosen_psk));
RESULT_ENSURE_REF(conn->psk_params.chosen_psk);
RESULT_GUARD(s2n_psk_init(conn->psk_params.chosen_psk, S2N_PSK_TYPE_EXTERNAL));
RESULT_GUARD_POSIX(s2n_psk_set_identity(conn->psk_params.chosen_psk, psk_identity, sizeof(psk_identity)));
return S2N_RESULT_OK;
}
int main(int argc, char **argv)
{
BEGIN_TEST();
EXPECT_SUCCESS(s2n_disable_tls13_in_test());
char dhparams_pem[S2N_MAX_TEST_PEM_SIZE] = { 0 };
EXPECT_SUCCESS(s2n_read_test_pem(S2N_DEFAULT_TEST_DHPARAMS, dhparams_pem,
S2N_MAX_TEST_PEM_SIZE));
/* Test client cipher selection */
{
/* Setup connections */
struct s2n_connection *conn = NULL;
EXPECT_NOT_NULL(conn = s2n_connection_new(S2N_CLIENT));
/* Setup config */
struct s2n_cert_chain_and_key *chain_and_key = NULL;
EXPECT_SUCCESS(s2n_test_cert_chain_and_key_new(&chain_and_key,
S2N_DEFAULT_TEST_CERT_CHAIN, S2N_DEFAULT_TEST_PRIVATE_KEY));
struct s2n_config *config = NULL;
EXPECT_NOT_NULL(config = s2n_config_new());
EXPECT_SUCCESS(s2n_config_add_cert_chain_and_key_to_store(config, chain_and_key));
EXPECT_SUCCESS(s2n_connection_set_config(conn, config));
/* Test that the client allows the server to select ciphers that were offered in ClientHello */
{
conn->client_protocol_version = S2N_TLS13;
conn->actual_protocol_version = S2N_TLS13;
conn->server_protocol_version = S2N_TLS13;
/* The client will offer the default tls13 ciphersuites */
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "default_tls13"));
/* The server will send a TLS13 cipher over the wire */
uint8_t valid_wire_ciphers[] = {
TLS_AES_128_GCM_SHA256
};
/* We expect to succeed because the cipher was offered by the client */
EXPECT_SUCCESS(s2n_set_cipher_as_client(conn, valid_wire_ciphers));
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Test that the client rejects a cipher that was not originally offered in ClientHello */
{
conn->client_protocol_version = S2N_TLS13;
conn->actual_protocol_version = S2N_TLS13;
conn->server_protocol_version = S2N_TLS13;
/* The client will offer the default tls13 ciphersuites */
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all_tls13"));
/* The server will send a TLS12 cipher over the wire */
uint8_t invalid_wire_ciphers[] = {
TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
};
/* We expect to fail because the cipher was not offered by the client */
EXPECT_FAILURE_WITH_ERRNO(s2n_set_cipher_as_client(conn, invalid_wire_ciphers), S2N_ERR_CIPHER_NOT_SUPPORTED);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/** Clients MUST verify
*= https://www.rfc-editor.org/rfc/rfc8446#section-4.2.11
*= type=test
*# that the server selected a cipher suite
*# indicating a Hash associated with the PSK
**/
{
/* If chosen PSK is set, test error case for incorrect hash match */
{
s2n_connection_set_cipher_preferences(conn, "default_tls13");
EXPECT_OK(s2n_conn_set_chosen_psk(conn));
uint8_t valid_tls13_wire_ciphers[] = {
TLS_AES_128_GCM_SHA256,
};
/* S2N_HMAC_SHA1 is not a matching hmac algorithm */
conn->psk_params.chosen_psk->hmac_alg = S2N_HMAC_SHA1;
EXPECT_FAILURE_WITH_ERRNO(s2n_set_cipher_as_client(conn, valid_tls13_wire_ciphers),
S2N_ERR_CIPHER_NOT_SUPPORTED);
EXPECT_EQUAL(conn->secure->cipher_suite, &s2n_null_cipher_suite);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* If chosen PSK is set, test success case for matching hash algorithm */
{
s2n_connection_set_cipher_preferences(conn, "default_tls13");
EXPECT_OK(s2n_conn_set_chosen_psk(conn));
uint8_t valid_tls13_wire_ciphers[] = {
TLS_AES_128_GCM_SHA256,
};
/* S2N_HMAC_SHA256 is a matching hmac algorithm for the cipher suite present in valid_tls13_wire_ciphers */
conn->psk_params.chosen_psk->hmac_alg = S2N_HMAC_SHA256;
EXPECT_SUCCESS(s2n_set_cipher_as_client(conn, valid_tls13_wire_ciphers));
EXPECT_EQUAL(conn->secure->cipher_suite, &s2n_tls13_aes_128_gcm_sha256);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
};
EXPECT_SUCCESS(s2n_connection_free(conn));
EXPECT_SUCCESS(s2n_cert_chain_and_key_free(chain_and_key));
EXPECT_SUCCESS(s2n_config_free(config));
};
/* Test server cipher selection and scsv detection */
{
struct s2n_connection *conn = NULL;
struct s2n_config *server_config = NULL;
char *rsa_cert_chain_pem = NULL, *rsa_private_key_pem = NULL, *ecdsa_cert_chain_pem = NULL, *ecdsa_private_key_pem = NULL;
struct s2n_cert_chain_and_key *rsa_cert = NULL, *ecdsa_cert = NULL;
/* Allocate all of the objects and PEMs we'll need for this test. */
EXPECT_NOT_NULL(rsa_cert_chain_pem = malloc(S2N_MAX_TEST_PEM_SIZE));
EXPECT_NOT_NULL(rsa_private_key_pem = malloc(S2N_MAX_TEST_PEM_SIZE));
EXPECT_NOT_NULL(ecdsa_cert_chain_pem = malloc(S2N_MAX_TEST_PEM_SIZE));
EXPECT_NOT_NULL(ecdsa_private_key_pem = malloc(S2N_MAX_TEST_PEM_SIZE));
EXPECT_NOT_NULL(conn = s2n_connection_new(S2N_SERVER));
EXPECT_NOT_NULL(rsa_cert = s2n_cert_chain_and_key_new());
EXPECT_NOT_NULL(ecdsa_cert = s2n_cert_chain_and_key_new());
EXPECT_SUCCESS(s2n_read_test_pem(S2N_DEFAULT_TEST_CERT_CHAIN, rsa_cert_chain_pem, S2N_MAX_TEST_PEM_SIZE));
EXPECT_SUCCESS(s2n_read_test_pem(S2N_DEFAULT_TEST_PRIVATE_KEY, rsa_private_key_pem, S2N_MAX_TEST_PEM_SIZE));
EXPECT_SUCCESS(s2n_read_test_pem(S2N_ECDSA_P384_PKCS1_CERT_CHAIN, ecdsa_cert_chain_pem, S2N_MAX_TEST_PEM_SIZE));
EXPECT_SUCCESS(s2n_read_test_pem(S2N_ECDSA_P384_PKCS1_KEY, ecdsa_private_key_pem, S2N_MAX_TEST_PEM_SIZE));
EXPECT_SUCCESS(s2n_cert_chain_and_key_load_pem(rsa_cert, rsa_cert_chain_pem, rsa_private_key_pem));
EXPECT_SUCCESS(s2n_cert_chain_and_key_load_pem(ecdsa_cert, ecdsa_cert_chain_pem, ecdsa_private_key_pem));
uint8_t wire_ciphers[] = {
TLS_RSA_WITH_RC4_128_MD5,
TLS_RSA_WITH_RC4_128_SHA,
TLS_RSA_WITH_3DES_EDE_CBC_SHA,
TLS_DHE_RSA_WITH_3DES_EDE_CBC_SHA,
TLS_RSA_WITH_AES_128_CBC_SHA,
TLS_DHE_RSA_WITH_AES_128_CBC_SHA,
TLS_RSA_WITH_AES_256_CBC_SHA,
TLS_DHE_RSA_WITH_AES_256_CBC_SHA,
TLS_RSA_WITH_AES_128_CBC_SHA256,
TLS_RSA_WITH_AES_256_CBC_SHA256,
TLS_DHE_RSA_WITH_AES_128_CBC_SHA256,
TLS_DHE_RSA_WITH_AES_256_CBC_SHA256,
TLS_RSA_WITH_AES_128_GCM_SHA256,
TLS_RSA_WITH_AES_256_GCM_SHA384,
TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256,
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384,
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
TLS_ECDHE_KYBER_RSA_WITH_AES_256_GCM_SHA384,
};
const uint8_t cipher_count = sizeof(wire_ciphers) / S2N_TLS_CIPHER_SUITE_LEN;
uint8_t wire_ciphers_fallback[] = {
TLS_RSA_WITH_RC4_128_MD5,
TLS_RSA_WITH_RC4_128_SHA,
TLS_RSA_WITH_3DES_EDE_CBC_SHA,
TLS_DHE_RSA_WITH_3DES_EDE_CBC_SHA,
TLS_RSA_WITH_AES_128_CBC_SHA,
TLS_DHE_RSA_WITH_AES_128_CBC_SHA,
TLS_RSA_WITH_AES_256_CBC_SHA,
TLS_DHE_RSA_WITH_AES_256_CBC_SHA,
TLS_RSA_WITH_AES_128_CBC_SHA256,
TLS_RSA_WITH_AES_256_CBC_SHA256,
TLS_DHE_RSA_WITH_AES_128_CBC_SHA256,
TLS_DHE_RSA_WITH_AES_256_CBC_SHA256,
TLS_RSA_WITH_AES_128_GCM_SHA256,
TLS_RSA_WITH_AES_256_GCM_SHA384,
TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256,
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384,
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
TLS_FALLBACK_SCSV, /* At the end to verify it isn't missed */
};
const uint8_t cipher_count_fallback = sizeof(wire_ciphers_fallback) / S2N_TLS_CIPHER_SUITE_LEN;
uint8_t wire_ciphers_renegotiation[] = {
TLS_RSA_WITH_RC4_128_MD5,
TLS_RSA_WITH_RC4_128_SHA,
TLS_RSA_WITH_3DES_EDE_CBC_SHA,
TLS_DHE_RSA_WITH_3DES_EDE_CBC_SHA,
TLS_RSA_WITH_AES_128_CBC_SHA,
TLS_DHE_RSA_WITH_AES_128_CBC_SHA,
TLS_RSA_WITH_AES_256_CBC_SHA,
TLS_DHE_RSA_WITH_AES_256_CBC_SHA,
TLS_RSA_WITH_AES_128_CBC_SHA256,
TLS_RSA_WITH_AES_256_CBC_SHA256,
TLS_DHE_RSA_WITH_AES_128_CBC_SHA256,
TLS_DHE_RSA_WITH_AES_256_CBC_SHA256,
TLS_RSA_WITH_AES_128_GCM_SHA256,
TLS_RSA_WITH_AES_256_GCM_SHA384,
TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA,
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256,
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384,
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
TLS_DHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
TLS_EMPTY_RENEGOTIATION_INFO_SCSV, /* At the end to verify it isn't missed */
};
const uint8_t cipher_count_renegotiation = sizeof(wire_ciphers_renegotiation) / S2N_TLS_CIPHER_SUITE_LEN;
/* Only two ciphers for testing RSA vs ECDSA. */
uint8_t wire_ciphers_with_ecdsa[] = {
TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA,
};
const uint8_t cipher_count_ecdsa = sizeof(wire_ciphers_with_ecdsa) / S2N_TLS_CIPHER_SUITE_LEN;
/* Only ECDSA ciphers */
uint8_t wire_ciphers_only_ecdsa[] = {
TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,
TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,
TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,
};
const uint8_t cipher_count_only_ecdsa = sizeof(wire_ciphers_only_ecdsa) / S2N_TLS_CIPHER_SUITE_LEN;
uint8_t wire_ciphers_rsa_fallback[] = {
TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,
TLS_ECDHE_ECDSA_WITH_AES_256_CBC_SHA,
TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,
TLS_ECDHE_ECDSA_WITH_AES_128_CBC_SHA256,
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256,
TLS_RSA_WITH_AES_256_GCM_SHA384,
};
const uint8_t cipher_count_rsa_fallback = sizeof(wire_ciphers_rsa_fallback) / S2N_TLS_CIPHER_SUITE_LEN;
EXPECT_NOT_NULL(server_config = s2n_config_new());
EXPECT_SUCCESS(s2n_config_add_cert_chain_and_key_to_store(server_config, rsa_cert));
/* Security policy must allow all test cipher suites */
EXPECT_SUCCESS(s2n_config_set_cipher_preferences(server_config, "test_all"));
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
/* TEST RSA */
conn->actual_protocol_version = S2N_TLS10;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers, cipher_count));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(1, s2n_connection_is_valid_for_cipher_preferences(conn, "test_all"));
EXPECT_EQUAL(0, s2n_connection_is_valid_for_cipher_preferences(conn, "null"));
EXPECT_SUCCESS(s2n_connection_wipe(conn));
/* TEST RENEGOTIATION
*
*= https://www.rfc-editor.org/rfc/rfc5746#3.6
*= type=test
*# o When a ClientHello is received, the server MUST check if it
*# includes the TLS_EMPTY_RENEGOTIATION_INFO_SCSV SCSV. If it does,
*# set the secure_renegotiation flag to TRUE.
*/
conn->actual_protocol_version = S2N_TLS12;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_renegotiation, cipher_count_renegotiation));
EXPECT_EQUAL(conn->secure_renegotiation, 1);
EXPECT_EQUAL(1, s2n_connection_is_valid_for_cipher_preferences(conn, "test_all"));
EXPECT_EQUAL(-1, s2n_connection_is_valid_for_cipher_preferences(conn, "not_exist"));
EXPECT_SUCCESS(s2n_connection_wipe(conn));
/* Simulate a TLSv11 client to trigger the fallback error */
conn->actual_protocol_version = S2N_TLS11;
EXPECT_FAILURE(s2n_set_cipher_as_tls_server(conn, wire_ciphers_fallback, cipher_count_fallback));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(1, s2n_connection_is_valid_for_cipher_preferences(conn, "null"));
EXPECT_EQUAL(0, s2n_connection_is_valid_for_cipher_preferences(conn, "CloudFront-TLS-1-2-2018"));
EXPECT_EQUAL(0, s2n_connection_is_valid_for_cipher_preferences(conn, "CloudFront-TLS-1-2-2019"));
EXPECT_SUCCESS(s2n_connection_wipe(conn));
/* TEST RSA cipher chosen when ECDSA cipher is at top */
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_ecdsa_priority"));
const struct s2n_ecc_preferences *ecc_pref = NULL;
EXPECT_SUCCESS(s2n_connection_get_ecc_preferences(conn, &ecc_pref));
EXPECT_NOT_NULL(ecc_pref);
/* Assume default for negotiated curve. */
/* Shouldn't be necessary unless the test fails, but we want the failure to be obvious. */
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
const struct s2n_cipher_suite *expected_rsa_wire_choice = &s2n_ecdhe_rsa_with_aes_128_cbc_sha;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_ecdsa, cipher_count_ecdsa));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_rsa_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
/* Test that PQ cipher suites are marked available/unavailable appropriately in s2n_cipher_suites_init() */
{
const struct s2n_cipher_suite *pq_suites[] = {
&s2n_ecdhe_kyber_rsa_with_aes_256_gcm_sha384,
};
for (size_t i = 0; i < s2n_array_len(pq_suites); i++) {
if (s2n_pq_is_enabled()) {
EXPECT_EQUAL(pq_suites[i]->available, 1);
EXPECT_NOT_NULL(pq_suites[i]->record_alg);
} else {
EXPECT_EQUAL(pq_suites[i]->available, 0);
EXPECT_NULL(pq_suites[i]->record_alg);
}
}
};
/* Test that clients that support PQ ciphers can negotiate them. */
{
uint8_t client_extensions_data[] = {
0xFE, 0x01, /* PQ KEM extension ID */
0x00, 0x04, /* Total extension length in bytes */
0x00, 0x02, /* Length of the supported parameters list in bytes */
0x00, TLS_PQ_KEM_EXTENSION_ID_KYBER_512_R3 /* Kyber-512-Round3*/
};
int client_extensions_len = sizeof(client_extensions_data);
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "PQ-TLS-1-0-2021-05-24"));
conn->actual_protocol_version = S2N_TLS12;
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->kex_params.client_pq_kem_extension.data = client_extensions_data;
conn->kex_params.client_pq_kem_extension.size = client_extensions_len;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers, cipher_count));
const struct s2n_cipher_suite *kyber_cipher = &s2n_ecdhe_kyber_rsa_with_aes_256_gcm_sha384;
const struct s2n_cipher_suite *ecc_cipher = &s2n_ecdhe_rsa_with_aes_256_gcm_sha384;
if (s2n_pq_is_enabled()) {
EXPECT_EQUAL(conn->secure->cipher_suite, kyber_cipher);
} else {
EXPECT_EQUAL(conn->secure->cipher_suite, ecc_cipher);
}
EXPECT_SUCCESS(s2n_connection_wipe(conn));
/* Test cipher preferences that use PQ cipher suites that require TLS 1.2 fall back to classic ciphers if a client
* only supports TLS 1.1 or below, TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA is the first cipher suite that supports
* TLS 1.1 in KMS-PQ-TLS-1-0-2019-06 */
for (int i = S2N_TLS10; i <= S2N_TLS11; i++) {
const struct s2n_cipher_suite *expected_classic_wire_choice = &s2n_ecdhe_rsa_with_aes_256_cbc_sha;
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "KMS-PQ-TLS-1-0-2019-06"));
conn->actual_protocol_version = i;
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->kex_params.client_pq_kem_extension.data = client_extensions_data;
conn->kex_params.client_pq_kem_extension.size = client_extensions_len;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers, cipher_count));
EXPECT_EQUAL(conn->secure->cipher_suite, expected_classic_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
}
};
/* Clean+free to setup for ECDSA tests */
EXPECT_SUCCESS(s2n_config_free(server_config));
/* Set ECDSA CERT in s2n_config */
EXPECT_NOT_NULL(server_config = s2n_config_new());
EXPECT_SUCCESS(s2n_config_add_cert_chain_and_key_to_store(server_config, ecdsa_cert));
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
EXPECT_SUCCESS(s2n_connection_get_ecc_preferences(conn, &ecc_pref));
EXPECT_NOT_NULL(ecc_pref);
/* TEST ECDSA */
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all_ecdsa"));
const struct s2n_cipher_suite *expected_ecdsa_wire_choice = &s2n_ecdhe_ecdsa_with_aes_128_cbc_sha256;
/* Assume default for negotiated curve. */
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_ecdsa, cipher_count_ecdsa));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_ecdsa_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
/* TEST ECDSA cipher chosen when RSA cipher is at top */
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all"));
/* Assume default for negotiated curve. */
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_ecdsa, cipher_count_ecdsa));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_ecdsa_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
EXPECT_SUCCESS(s2n_config_free(server_config));
/* TEST two certificates. Use two certs with different key types(RSA, ECDSA) and add them to a single
* s2n_config.
*/
EXPECT_NOT_NULL(server_config = s2n_config_new());
EXPECT_SUCCESS(s2n_config_add_cert_chain_and_key_to_store(server_config, rsa_cert));
EXPECT_SUCCESS(s2n_config_add_cert_chain_and_key_to_store(server_config, ecdsa_cert));
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
/* Client sends RSA and ECDSA ciphers, server prioritizes ECDSA, ECDSA + RSA cert is configured */
{
const struct s2n_cipher_suite *expected_wire_choice = &s2n_ecdhe_ecdsa_with_aes_128_cbc_sha256;
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_ecdsa_priority"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_ecdsa, cipher_count_ecdsa));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Client sends RSA and ECDSA ciphers, server prioritizes RSA, ECDSA + RSA cert is configured */
{
const struct s2n_cipher_suite *expected_wire_choice = &s2n_ecdhe_rsa_with_aes_128_cbc_sha;
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_ecdsa, cipher_count_ecdsa));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Client sends both RSA and ECDSA ciphers, server only configures RSA ciphers,
* ECDSA + RSA cert is configured.
*/
{
const struct s2n_cipher_suite *expected_wire_choice = &s2n_ecdhe_rsa_with_aes_128_cbc_sha;
/* 20170328 only supports RSA ciphers */
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "20170328"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_ecdsa, cipher_count_ecdsa));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Client sends both RSA and ECDSA ciphers, server only configures ECDSA ciphers, ECDSA + RSA cert is
* configured.
*/
{
const struct s2n_cipher_suite *expected_wire_choice = &s2n_ecdhe_ecdsa_with_aes_128_cbc_sha256;
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all_ecdsa"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_ecdsa, cipher_count_ecdsa));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Client only sends RSA ciphers, server prioritizes ECDSA ciphers, ECDSA + RSA cert is
* configured.
*/
{
const struct s2n_cipher_suite *expected_wire_choice = &s2n_rsa_with_rc4_128_md5;
if (!expected_wire_choice->available) {
expected_wire_choice = &s2n_rsa_with_3des_ede_cbc_sha;
}
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_ecdsa_priority"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers, cipher_count));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Client only sends ECDSA ciphers, server prioritizes ECDSA ciphers, ECDSA + RSA cert is
* configured.
*/
{
const struct s2n_cipher_suite *expected_wire_choice = &s2n_ecdhe_ecdsa_with_aes_256_cbc_sha;
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_ecdsa_priority"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_only_ecdsa, cipher_count_only_ecdsa));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Client sends ECDHE-ECDSA, RSA, ECDHE-RSA ciphers. Server prioritizes ECDSA but also supports RSA.
* No mutually supported elliptic curves between client and server. ECDSA + RSA cert is configured.
*/
{
/* If there are no shared elliptic curves, we must fall through to a cipher that supports RSA kx.
* This is the first RSA kx cipher that CloudFront-Upstream supports.
*/
const struct s2n_cipher_suite *expected_wire_choice = &s2n_rsa_with_aes_256_gcm_sha384;
/* Selecting this preference list because it prioritizes ECDHE-ECDSA and ECDHE-RSA over plain RSA kx. */
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "CloudFront-Upstream"));
/* No shared curve */
conn->kex_params.server_ecc_evp_params.negotiated_curve = NULL;
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_rsa_fallback, cipher_count_rsa_fallback));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
EXPECT_SUCCESS(s2n_config_free(server_config));
EXPECT_NOT_NULL(server_config = s2n_config_new());
EXPECT_SUCCESS(s2n_config_add_cert_chain_and_key_to_store(server_config, rsa_cert));
EXPECT_SUCCESS(s2n_config_add_cert_chain_and_key_to_store(server_config, ecdsa_cert));
/* Override auto-chosen defaults with only RSA cert default. ECDSA still loaded, but not default. */
EXPECT_SUCCESS(s2n_config_set_cert_chain_and_key_defaults(server_config, &rsa_cert, 1));
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
/* Client sends RSA and ECDSA ciphers, server prioritizes ECDSA, ECDSA + RSA cert is configured,
* only RSA is default. Expect default RSA used instead of previous test that expects ECDSA for this case. */
{
const struct s2n_cipher_suite *expected_wire_choice = &s2n_ecdhe_rsa_with_aes_128_cbc_sha;
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_ecdsa_priority"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_ecdsa, cipher_count_ecdsa));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Override auto-chosen defaults with only ECDSA cert default. RSA still loaded, but not default. */
EXPECT_SUCCESS(s2n_config_set_cert_chain_and_key_defaults(server_config, &ecdsa_cert, 1));
/* Client sends RSA and ECDSA ciphers, server prioritizes RSA, ECDSA + RSA cert is configured,
* only ECDSA is default. Expect default ECDSA used instead of previous test that expects RSA for this case. */
{
const struct s2n_cipher_suite *expected_wire_choice = &s2n_ecdhe_ecdsa_with_aes_128_cbc_sha256;
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_ecdsa, cipher_count_ecdsa));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Test override back to both RSA and ECDSA defaults. */
struct s2n_cert_chain_and_key *certs_list[] = { rsa_cert, ecdsa_cert };
EXPECT_SUCCESS(s2n_config_set_cert_chain_and_key_defaults(server_config, certs_list, 2));
/* Client sends RSA and ECDSA ciphers, server prioritizes ECDSA, ECDSA + RSA cert is configured */
{
const struct s2n_cipher_suite *expected_wire_choice = &s2n_ecdhe_ecdsa_with_aes_128_cbc_sha256;
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_ecdsa_priority"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_ecdsa, cipher_count_ecdsa));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Test that defaults are not overriden after failures to set new default certificates */
EXPECT_FAILURE_WITH_ERRNO_NO_RESET(s2n_config_set_cert_chain_and_key_defaults(server_config, NULL, 0), S2N_ERR_NULL);
EXPECT_EQUAL(strcmp(s2n_strerror_name(s2n_errno), "S2N_ERR_NULL"), 0);
EXPECT_FAILURE_WITH_ERRNO_NO_RESET(s2n_config_set_cert_chain_and_key_defaults(server_config, &rsa_cert, 0),
S2N_ERR_NUM_DEFAULT_CERTIFICATES);
EXPECT_EQUAL(strcmp(s2n_strerror_name(s2n_errno), "S2N_ERR_NUM_DEFAULT_CERTIFICATES"), 0);
struct s2n_cert_chain_and_key *rsa_certs_list[] = { rsa_cert, rsa_cert };
EXPECT_FAILURE_WITH_ERRNO_NO_RESET(s2n_config_set_cert_chain_and_key_defaults(server_config, rsa_certs_list, 2),
S2N_ERR_MULTIPLE_DEFAULT_CERTIFICATES_PER_AUTH_TYPE);
EXPECT_EQUAL(strcmp(s2n_strerror_name(s2n_errno), "S2N_ERR_MULTIPLE_DEFAULT_CERTIFICATES_PER_AUTH_TYPE"), 0);
/* Client sends RSA and ECDSA ciphers, server prioritizes RSA, ECDSA + RSA cert is configured.
* RSA default certificate should be chosen. */
{
const struct s2n_cipher_suite *expected_wire_choice = &s2n_ecdhe_rsa_with_aes_128_cbc_sha;
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = ecc_pref->ecc_curves[0];
conn->actual_protocol_version = conn->server_protocol_version;
EXPECT_SUCCESS(s2n_connection_set_config(conn, server_config));
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_ecdsa, cipher_count_ecdsa));
EXPECT_EQUAL(conn->secure_renegotiation, 0);
EXPECT_EQUAL(conn->secure->cipher_suite, expected_wire_choice);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
struct s2n_cipher_suite *tls12_cipher_suite = cipher_preferences_20170210.suites[cipher_preferences_20170210.count - 1];
uint8_t wire_ciphers_with_tls13[] = {
TLS_AES_128_GCM_SHA256,
TLS_AES_256_GCM_SHA384,
TLS_CHACHA20_POLY1305_SHA256,
tls12_cipher_suite->iana_value[0], tls12_cipher_suite->iana_value[1]
};
const uint8_t cipher_count_tls13 = sizeof(wire_ciphers_with_tls13) / S2N_TLS_CIPHER_SUITE_LEN;
/* Client sends TLS1.3 cipher suites, but server does not support TLS1.3 */
{
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all"));
conn->client_protocol_version = S2N_TLS13;
conn->actual_protocol_version = S2N_TLS12;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_tls13, cipher_count_tls13));
EXPECT_EQUAL(conn->secure->cipher_suite, tls12_cipher_suite);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Client sends TLS1.3 cipher suites, server selects correct TLS1.3 ciphersuite */
if (s2n_is_tls13_fully_supported()) {
struct test_case {
const char *cipher_pref;
const struct s2n_cipher_suite *expected_cipher_wire;
};
struct test_case test_cases[] = {
{ .cipher_pref = "default_tls13", .expected_cipher_wire = &s2n_tls13_aes_128_gcm_sha256 },
{ .cipher_pref = "test_all", .expected_cipher_wire = &s2n_tls13_aes_128_gcm_sha256 },
{ .cipher_pref = "test_all_tls13", .expected_cipher_wire = &s2n_tls13_aes_128_gcm_sha256 },
};
for (size_t i = 0; i < s2n_array_len(test_cases); i++) {
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, test_cases[i].cipher_pref));
conn->client_protocol_version = S2N_TLS13;
conn->actual_protocol_version = S2N_TLS13;
conn->server_protocol_version = S2N_TLS13;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_tls13, cipher_count_tls13));
EXPECT_EQUAL(conn->secure->cipher_suite, test_cases[i].expected_cipher_wire);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
}
}
/* Check wire's cipher suites with preferred tls12 ordering does not affect tls13 selection */
{
uint8_t wire_ciphers2[] = {
TLS_RSA_WITH_3DES_EDE_CBC_SHA,
TLS_ECDHE_RSA_WITH_3DES_EDE_CBC_SHA,
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, /* tls 1.2 */
TLS_CHACHA20_POLY1305_SHA256, /* tls 1.3 */
};
const uint8_t count = sizeof(wire_ciphers2) / S2N_TLS_CIPHER_SUITE_LEN;
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all"));
conn->client_protocol_version = S2N_TLS13;
conn->actual_protocol_version = S2N_TLS13;
conn->server_protocol_version = S2N_TLS13;
if (s2n_chacha20_poly1305.is_available()) {
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers2, count));
EXPECT_EQUAL(conn->secure->cipher_suite, &s2n_tls13_chacha20_poly1305_sha256);
} else {
EXPECT_FAILURE(s2n_set_cipher_as_tls_server(conn, wire_ciphers2, count));
}
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Test cipher suite with a required version higher than what connection supports should not be selected */
{
uint8_t test_wire_ciphers[] = {
TLS_AES_128_GCM_SHA256, /* tls 1.3 */
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, /* tls 1.2 */
};
const uint8_t count = sizeof(test_wire_ciphers) / S2N_TLS_CIPHER_SUITE_LEN;
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all"));
conn->actual_protocol_version = S2N_TLS12;
conn->kex_params.server_ecc_evp_params.negotiated_curve = s2n_all_supported_curves_list[0];
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, test_wire_ciphers, count));
EXPECT_EQUAL(conn->secure->cipher_suite, &s2n_ecdhe_rsa_with_aes_128_gcm_sha256);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* We should skip cipher suites with a minimum protocol version unsupported by the connection.
* If no valid cipher suite is found, we should fall back to a cipher suite with a higher protocol version,
* but we should NEVER use a TLS1.3 suite on a pre-TLS1.3 connection or vice versa. */
{
/* Skip but fall back to cipher suite with protocol version higher than connection */
{
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = s2n_all_supported_curves_list[0];
uint8_t test_wire_ciphers[] = {
TLS_AES_128_GCM_SHA256, /* tls 1.3 */
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, /* tls 1.2 */
TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA, /* ssl v3 */
};
conn->actual_protocol_version = S2N_TLS10;
/* If a match exists, skip the invalid cipher and choose it */
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, test_wire_ciphers, 3));
EXPECT_EQUAL(conn->secure->cipher_suite, &s2n_ecdhe_rsa_with_aes_128_cbc_sha);
/* If a match does not exist, choose the invalid cipher */
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, test_wire_ciphers, 2));
EXPECT_EQUAL(conn->secure->cipher_suite, &s2n_ecdhe_rsa_with_aes_128_gcm_sha256);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* Skip and do NOT fall back to a TLS1.3 cipher suite if using TLS1.2 */
{
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = s2n_all_supported_curves_list[0];
uint8_t test_wire_ciphers[] = {
TLS_AES_128_GCM_SHA256, /* tls 1.3 */
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, /* tls 1.2 */
};
conn->actual_protocol_version = S2N_TLS12;
/* If a match exists, skip the invalid cipher and choose it */
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, test_wire_ciphers, 2));
EXPECT_EQUAL(conn->secure->cipher_suite, &s2n_ecdhe_rsa_with_aes_128_gcm_sha256);
/* If a match does not exist, fail to negotiate a cipher suite.
* We cannot fall back to the TLS1.3 choice. */
EXPECT_FAILURE_WITH_ERRNO(s2n_set_cipher_as_tls_server(conn, test_wire_ciphers, 1),
S2N_ERR_CIPHER_NOT_SUPPORTED);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
}
/* Skip and do NOT fall back to a TLS1.2 cipher suite if using TLS1.3 */
{
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "test_all"));
conn->kex_params.server_ecc_evp_params.negotiated_curve = s2n_all_supported_curves_list[0];
uint8_t test_wire_ciphers[] = {
TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256, /* tls 1.2 */
TLS_AES_128_GCM_SHA256, /* tls 1.3 */
};
conn->actual_protocol_version = S2N_TLS13;
/* If a match exists, skip the invalid cipher and choose it */
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, test_wire_ciphers, 2));
EXPECT_EQUAL(conn->secure->cipher_suite, &s2n_tls13_aes_128_gcm_sha256);
/* If a match does not exist, fail to negotiate a cipher suite.
* We cannot fall back to the TLS1.2 choice. */
EXPECT_FAILURE_WITH_ERRNO(s2n_set_cipher_as_tls_server(conn, test_wire_ciphers, 1),
S2N_ERR_CIPHER_NOT_SUPPORTED);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
}
};
/* If a PSK is being used, then the cipher suite must match the PSK's HMAC algorithm.
*
*= https://www.rfc-editor.org/rfc/rfc8446#section-4.2.11
*= type=test
*# The server MUST ensure that it selects a compatible PSK
*# (if any) and cipher suite.
**/
{
/* If chosen PSK is set, a cipher suite with matching HMAC algorithm must be selected */
{
s2n_connection_set_cipher_preferences(conn, "test_all");
conn->kex_params.server_ecc_evp_params.negotiated_curve = s2n_all_supported_curves_list[0];
conn->actual_protocol_version = S2N_TLS13;
EXPECT_OK(s2n_conn_set_chosen_psk(conn));
conn->psk_params.chosen_psk->hmac_alg = S2N_HMAC_SHA256;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_tls13, cipher_count_tls13));
EXPECT_EQUAL(conn->secure->cipher_suite->prf_alg, conn->psk_params.chosen_psk->hmac_alg);
conn->psk_params.chosen_psk->hmac_alg = S2N_HMAC_SHA384;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_tls13, cipher_count_tls13));
EXPECT_EQUAL(conn->secure->cipher_suite->prf_alg, conn->psk_params.chosen_psk->hmac_alg);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
/* If chosen PSK is set but there is no matching cipher, the server MUST fail to set a cipher */
{
s2n_connection_set_cipher_preferences(conn, "test_all");
conn->kex_params.server_ecc_evp_params.negotiated_curve = s2n_all_supported_curves_list[0];
conn->actual_protocol_version = S2N_TLS13;
/* S2N_HMAC_SHA1 is not a matching HMAC algorithm for any TLS1.3 cipher */
EXPECT_OK(s2n_conn_set_chosen_psk(conn));
conn->psk_params.chosen_psk->hmac_alg = S2N_HMAC_SHA1;
EXPECT_FAILURE_WITH_ERRNO(s2n_set_cipher_as_tls_server(conn, wire_ciphers_with_tls13, cipher_count_tls13),
S2N_ERR_CIPHER_NOT_SUPPORTED);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
};
};
/* Client sends cipher which is not in the configured suite */
{
EXPECT_SUCCESS(s2n_enable_tls13_in_test());
uint8_t invalid_cipher_pref[] = {
TLS_ECDHE_KYBER_RSA_WITH_AES_256_GCM_SHA384
};
const uint8_t invalid_cipher_count = sizeof(invalid_cipher_pref) / S2N_TLS_CIPHER_SUITE_LEN;
EXPECT_SUCCESS(s2n_connection_set_cipher_preferences(conn, "default_tls13"));
conn->client_protocol_version = S2N_TLS13;
conn->actual_protocol_version = S2N_TLS13;
EXPECT_FAILURE_WITH_ERRNO(s2n_set_cipher_as_tls_server(conn, invalid_cipher_pref, invalid_cipher_count), S2N_ERR_CIPHER_NOT_SUPPORTED);
EXPECT_SUCCESS(s2n_connection_wipe(conn));
EXPECT_SUCCESS(s2n_disable_tls13_in_test());
};
/* Client sends cipher that requires DH params */
{
DEFER_CLEANUP(struct s2n_config *config = s2n_config_new(),
s2n_config_ptr_free);
EXPECT_SUCCESS(s2n_config_set_cipher_preferences(config, "test_all"));
EXPECT_SUCCESS(s2n_config_add_cert_chain_and_key_to_store(config, rsa_cert));
DEFER_CLEANUP(struct s2n_connection *server = s2n_connection_new(S2N_SERVER),
s2n_connection_ptr_free);
EXPECT_NOT_NULL(server);
EXPECT_SUCCESS(s2n_connection_set_config(server, config));
/* The client only offers one cipher suite, which requires dh kex */
uint8_t wire[] = { TLS_DHE_RSA_WITH_AES_128_GCM_SHA256 };
/* By default, the server does not accept cipher suites with dh kex. */
EXPECT_FAILURE_WITH_ERRNO(s2n_set_cipher_as_tls_server(server, wire, 1),
S2N_ERR_CIPHER_NOT_SUPPORTED);
/* With dh params configured, the server accepts cipher suites with dh kex. */
EXPECT_SUCCESS(s2n_config_add_dhparams(config, dhparams_pem));
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(server, wire, 1));
EXPECT_EQUAL(server->secure->cipher_suite, &s2n_dhe_rsa_with_aes_128_gcm_sha256);
};
EXPECT_SUCCESS(s2n_config_free(server_config));
EXPECT_SUCCESS(s2n_cert_chain_and_key_free(rsa_cert));
EXPECT_SUCCESS(s2n_cert_chain_and_key_free(ecdsa_cert));
free(ecdsa_cert_chain_pem);
free(ecdsa_private_key_pem);
free(rsa_cert_chain_pem);
free(rsa_private_key_pem);
EXPECT_SUCCESS(s2n_connection_free(conn));
};
/* Test chacha20 boosting behaviour */
{
/* Setup cipher preferences + security policy */
struct s2n_cipher_preferences cipher_preferences = { 0 };
struct s2n_security_policy security_policy = {
.minimum_protocol_version = S2N_SSLv2,
.cipher_preferences = &cipher_preferences,
.kem_preferences = &kem_preferences_null,
.signature_preferences = &s2n_signature_preferences_20201021,
.ecc_preferences = &s2n_ecc_preferences_test_all,
};
/* Initialise config and relevant certs */
DEFER_CLEANUP(struct s2n_config *server_config = s2n_config_new(), s2n_config_ptr_free);
struct s2n_cert_chain_and_key *rsa_cert = NULL;
struct s2n_cert_chain_and_key *ecdsa_cert = NULL;
EXPECT_SUCCESS(s2n_test_cert_chain_and_key_new(&rsa_cert,
S2N_DEFAULT_TEST_CERT_CHAIN, S2N_DEFAULT_TEST_PRIVATE_KEY));
EXPECT_SUCCESS(s2n_test_cert_chain_and_key_new(&ecdsa_cert,
S2N_DEFAULT_ECDSA_TEST_CERT_CHAIN, S2N_DEFAULT_ECDSA_TEST_PRIVATE_KEY));
EXPECT_NOT_NULL(rsa_cert);
EXPECT_NOT_NULL(ecdsa_cert);
EXPECT_NOT_NULL(server_config);
EXPECT_SUCCESS(s2n_config_add_cert_chain_and_key_to_store(server_config, rsa_cert));
EXPECT_SUCCESS(s2n_config_add_cert_chain_and_key_to_store(server_config, ecdsa_cert));
EXPECT_SUCCESS(s2n_config_set_cipher_preferences(server_config, "test_all"));
if (s2n_chacha20_poly1305.is_available()) {
/* Test chacha20 boosting when ciphersuites fail auth validation */
{
DEFER_CLEANUP(struct s2n_connection *connection = s2n_connection_new(S2N_SERVER), s2n_connection_ptr_free);
EXPECT_NOT_NULL(connection);
connection->security_policy_override = &security_policy;
connection->kex_params.server_ecc_evp_params.negotiated_curve = s2n_all_supported_curves_list[0];
EXPECT_SUCCESS(s2n_connection_set_all_protocol_versions(connection, S2N_TLS12));
DEFER_CLEANUP(struct s2n_config *rsa_only_config = s2n_config_new(), s2n_config_ptr_free);
EXPECT_NOT_NULL(rsa_only_config);
EXPECT_SUCCESS(s2n_config_add_cert_chain_and_key_to_store(rsa_only_config, rsa_cert));
/* Connection only supports rsa auth. */
EXPECT_SUCCESS(s2n_connection_set_config(connection, rsa_only_config));
static struct s2n_cipher_suite *test_cipher_suite_list[] = {
/* Not negotiated because invalid (ecdsa) */
&s2n_ecdhe_ecdsa_with_chacha20_poly1305_sha256,
/* Only negotiated if chacha20 boosting is disabled */
&s2n_ecdhe_rsa_with_aes_256_gcm_sha384,
/* First valid chacha20 cipher suite and is negotiated */
&s2n_ecdhe_rsa_with_chacha20_poly1305_sha256,
};
cipher_preferences = (struct s2n_cipher_preferences){
.count = s2n_array_len(test_cipher_suite_list),
.suites = test_cipher_suite_list,
.allow_chacha20_boosting = true,
};
uint8_t wire[] = {
/* Client signalled chacha20 boosting; valid chacha20 ciphersuite and is negotiated */
TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
/* Not negotiated because invalid (ecdsa) */
TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,
/* Negotiated if chacha20 boosting is off */
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384,
};
uint8_t count = sizeof(wire) / S2N_TLS_CIPHER_SUITE_LEN;
/* Verify chacha20 RSA ciphersuite chosen with chacha20 boosting enabled */
cipher_preferences.allow_chacha20_boosting = true;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(connection, wire, count));
EXPECT_EQUAL(connection->secure->cipher_suite, &s2n_ecdhe_rsa_with_chacha20_poly1305_sha256);
/* Sanity check: non-chacha20 RSA ciphersuite chosen without chacha20 boosting enabled */
/* cppcheck-suppress redundantAssignment */
cipher_preferences.allow_chacha20_boosting = false;
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(connection, wire, count));
EXPECT_EQUAL(connection->secure->cipher_suite, &s2n_ecdhe_rsa_with_aes_256_gcm_sha384);
};
/* Server is able to negotiate its most preferred chacha20 ciphersuite */
{
DEFER_CLEANUP(struct s2n_connection *connection = s2n_connection_new(S2N_SERVER), s2n_connection_ptr_free);
EXPECT_NOT_NULL(connection);
connection->security_policy_override = &security_policy;
connection->kex_params.server_ecc_evp_params.negotiated_curve = s2n_all_supported_curves_list[0];
EXPECT_SUCCESS(s2n_connection_set_all_protocol_versions(connection, S2N_TLS12));
EXPECT_SUCCESS(s2n_connection_set_config(connection, server_config));
static struct s2n_cipher_suite *test_cipher_suite_list[] = {
/* Skipped because it is not a chacha20 ciphersuite. Is negotiated if chacha20 boosting is disabled. */
&s2n_ecdhe_rsa_with_aes_256_cbc_sha384,
/* First chacha20 ciphersuite and is negotiated */
&s2n_ecdhe_ecdsa_with_chacha20_poly1305_sha256,
/* Second chacha20 ciphersuite and is not negotiated (not server's most preferred chacha20 ciphersuite) */
&s2n_ecdhe_rsa_with_chacha20_poly1305_sha256,
};
cipher_preferences = (struct s2n_cipher_preferences){
.count = s2n_array_len(test_cipher_suite_list),
.suites = test_cipher_suite_list,
.allow_chacha20_boosting = true
};
uint8_t wire[] = {
/* Client signalled chacha20 boosting: not negotiated because it's not server's most preferred chacha20 ciphersuite */
TLS_ECDHE_RSA_WITH_CHACHA20_POLY1305_SHA256,
/* Negotiated if chacha20 boosting is on */
TLS_ECDHE_ECDSA_WITH_CHACHA20_POLY1305_SHA256,
/* Negotiated if chacha20 boosting is off */
TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384,
};
uint8_t count = sizeof(wire) / S2N_TLS_CIPHER_SUITE_LEN;
/* Verify most preferred chacha20 ciphersuite is chosen with chacha20 boosting enabled */
EXPECT_SUCCESS(s2n_set_cipher_as_tls_server(connection, wire, count));
EXPECT_EQUAL(connection->secure->cipher_suite, &s2n_ecdhe_ecdsa_with_chacha20_poly1305_sha256);