-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a single module for generating image URIs #1464
Comments
This was referenced May 6, 2020
Closed
7 tasks
This was referenced Jun 15, 2020
7 tasks
This was referenced Jul 10, 2020
This was referenced Jul 17, 2020
Merged
7 tasks
This was referenced Jul 29, 2020
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
The code for determining an image URI for a given algorithm or framework is scattered across the Python SDK. In addition, the documentation on it is confusing. We used to have our own page for URIs, which now simply points to the DLC page, and that can cause its own confusion because there’s no longer documentation for older images or the SageMaker-style tags (e.g. “2.1.0-gpu-py3” as opposed to “2.1.0-gpu-py36-cu101-ubuntu18.04”).
Describe the solution you'd like
I’d like to create a new class,
ImageURIProvider
(open to naming suggestions), that houses all of our logic for creating an image URI. This would movecreate_image_uri
(and associated methods/constants) out offw_utils.py
andget_image_uri
(and associated methods/constants) out of the Amazon algorithm section. Similar logic from SKLearn, XGBoost,fw_registry.py
, etc. would also be moved to this new class.Proposed interface:
The methods are generic, as opposed to per framework/algorithm (e.g.
tensorflow_image_uri
,xgboost_image_uri
, etc.), but we can potentially define an enum to help validate the framework/algorithm name. There is also potential here to combine the two methods, and simply just have oneimage_uri
method for everything.This will be useful for Amazon algorithms that don't have a dedicated estimator (currently a use case of
get_image_uri
in many notebooks), getting a framework image URI to use as a base image or with boto3, and our own internal code cleanliness.The text was updated successfully, but these errors were encountered: